Merge pull request #471 from fredthomsen/RefactorH2ConfigTests

Update H2Configuration test to use init params

Author: Lukasa

test/test_config.py

@@ -31,42 +31,87 @@ def test_defaults(self):
 
     @pytest.mark.parametrize('option_name', boolean_config_options)
     @pytest.mark.parametrize('value', [None, 'False', 1])
-    def test_boolean_config_options_reject_non_bools(self, option_name, value):
+    def test_boolean_config_options_reject_non_bools_init(
+        self, option_name, value
+    ):
         """
         The boolean config options raise an error if you try to set a value
-        that isn't a boolean.
+        that isn't a boolean via the initializer.
         """
-        config = h2.config.H2Configuration()
+        with pytest.raises(ValueError):
+            h2.config.H2Configuration(**{option_name: value})
 
+    @pytest.mark.parametrize('option_name', boolean_config_options)
+    @pytest.mark.parametrize('value', [None, 'False', 1])
+    def test_boolean_config_options_reject_non_bools_attr(
+        self, option_name, value
+    ):
+        """
+        The boolean config options raise an error if you try to set a value
+        that isn't a boolean via attribute setter.
+        """
+        config = h2.config.H2Configuration()
         with pytest.raises(ValueError):
             setattr(config, option_name, value)
 
     @pytest.mark.parametrize('option_name', boolean_config_options)
     @pytest.mark.parametrize('value', [True, False])
-    def test_boolean_config_option_is_reflected(self, option_name, value):
+    def test_boolean_config_option_is_reflected_init(self, option_name, value):
         """
         The value of the boolean config options, when set, is reflected
-        in the value.
+        in the value via the initializer.
+        """
+        config = h2.config.H2Configuration(**{option_name: value})
+        assert getattr(config, option_name) == value
+
+    @pytest.mark.parametrize('option_name', boolean_config_options)
+    @pytest.mark.parametrize('value', [True, False])
+    def test_boolean_config_option_is_reflected_attr(self, option_name, value):
+        """
+        The value of the boolean config options, when set, is reflected
+        in the value via attribute setter.
         """
         config = h2.config.H2Configuration()
         setattr(config, option_name, value)
         assert getattr(config, option_name) == value
 
     @pytest.mark.parametrize('header_encoding', [True, 1, object()])
-    def test_header_encoding_must_be_false_str_none(self, header_encoding):
+    def test_header_encoding_must_be_false_str_none_init(
+        self, header_encoding
+    ):
         """
         The value of the ``header_encoding`` setting must be False, a string,
-        or None.
+        or None via the initializer.
         """
-        config = h2.config.H2Configuration()
+        with pytest.raises(ValueError):
+            h2.config.H2Configuration(header_encoding=header_encoding)
 
+    @pytest.mark.parametrize('header_encoding', [True, 1, object()])
+    def test_header_encoding_must_be_false_str_none_attr(
+        self, header_encoding
+    ):
+        """
+        The value of the ``header_encoding`` setting must be False, a string,
+        or None via attribute setter.
+        """
+        config = h2.config.H2Configuration()
         with pytest.raises(ValueError):
             config.header_encoding = header_encoding
 
     @pytest.mark.parametrize('header_encoding', [False, 'ascii', None])
-    def test_header_encoding_is_reflected(self, header_encoding):
+    def test_header_encoding_is_reflected_init(self, header_encoding):
+        """
+        The value of ``header_encoding``, when set, is reflected in the value
+        via the initializer.
+        """
+        config = h2.config.H2Configuration(header_encoding=header_encoding)
+        assert config.header_encoding == header_encoding
+
+    @pytest.mark.parametrize('header_encoding', [False, 'ascii', None])
+    def test_header_encoding_is_reflected_attr(self, header_encoding):
         """
-        The value of ``header_encoding``, when set, is reflected in the value.
+        The value of ``header_encoding``, when set, is reflected in the value
+        via the attribute setter.
         """
         config = h2.config.H2Configuration()
         config.header_encoding = header_encoding