Use new sdk + a bit cleanup + release (#54)

* Use new sdk + a bit cleanup + release

* Address reviews + add more comments

Author: ali-behjati

pyth-evm-price-pusher/docker-compose.mainnet.sample.yaml

@@ -14,7 +14,7 @@ services:
       - "--logLevel"
       - "debug"
   price-service:
-    image: public.ecr.aws/pyth-network/xc-server:v1.0.0
+    image: public.ecr.aws/pyth-network/xc-server:v2.0.0
     environment:
       SPY_SERVICE_HOST: "spy:7072"
       SPY_SERVICE_FILTERS: |
@@ -26,12 +26,12 @@ services:
           {
             "chain_id": 26,
             "emitter_address": "f8cd23c2ab91237730770bbea08d61005cdda0984348f3f6eecb559638c0bba0"
-          },
+          }
         ]
       REST_PORT: "4200"
       PROM_PORT: "8081"
-      READINESS_SPY_SYNC_TIME_SECONDS: "60"
-      READINESS_NUM_LOADED_SYMBOLS: "8"
+      READINESS_SPY_SYNC_TIME_SECONDS: "20"
+      READINESS_NUM_LOADED_SYMBOLS: "50"
       LOG_LEVEL: debug
     healthcheck:
       test:
@@ -43,7 +43,7 @@ services:
           "--spider",
           "http://localhost:4200/ready",
         ]
-      start_period: 60s
+      start_period: 20s
     depends_on:
       - spy
   price-pusher:

pyth-evm-price-pusher/docker-compose.testnet.sample.yaml

@@ -14,7 +14,7 @@ services:
       - "--logLevel"
       - "debug"
   price-service:
-    image: public.ecr.aws/pyth-network/xc-server:v1.0.0
+    image: public.ecr.aws/pyth-network/xc-server:v2.0.0
     environment:
       SPY_SERVICE_HOST: "spy:7072"
       SPY_SERVICE_FILTERS: |
@@ -26,12 +26,12 @@ services:
           {
             "chain_id": 26,
             "emitter_address": "a27839d641b07743c0cb5f68c51f8cd31d2c0762bec00dc6fcd25433ef1ab5b6"
-          },
+          }
         ]
       REST_PORT: "4200"
       PROM_PORT: "8081"
-      READINESS_SPY_SYNC_TIME_SECONDS: "60"
-      READINESS_NUM_LOADED_SYMBOLS: "8"
+      READINESS_SPY_SYNC_TIME_SECONDS: "20"
+      READINESS_NUM_LOADED_SYMBOLS: "50"
       LOG_LEVEL: debug
     healthcheck:
       test:
@@ -43,7 +43,7 @@ services:
           "--spider",
           "http://localhost:4200/ready",
         ]
-      start_period: 60s
+      start_period: 20s
     depends_on:
       - spy
   price-pusher:

pyth-evm-price-pusher/package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "@pythnetwork/pyth-evm-price-pusher",
-  "version": "0.3.0",
+  "version": "1.0.0",
   "description": "Pyth EVM Price Pusher",
   "homepage": "https://pyth.network",
   "main": "lib/index.js",
@@ -45,7 +45,7 @@
     "typescript": "^4.6.3"
   },
   "dependencies": {
-    "@pythnetwork/pyth-evm-js": "^0.5.0",
+    "@pythnetwork/pyth-evm-js": "^1.0.0",
     "@pythnetwork/pyth-sdk-solidity": "^1.0.1",
     "@truffle/hdwallet-provider": "^2.0.8",
     "joi": "^17.6.0",

pyth-evm-price-pusher/package.json

@@ -1,4 +1,4 @@
-import { HexString, PriceFeed } from "@pythnetwork/pyth-evm-js";
+import { HexString } from "@pythnetwork/pyth-evm-js";
 
 import AbstractPythAbi from "@pythnetwork/pyth-sdk-solidity/abis/AbstractPyth.json";
 import Web3 from "web3";
@@ -10,7 +10,6 @@ import {
   DurationInSeconds,
   isWsEndpoint,
   removeLeading0x,
-  statusNumberToEnum,
 } from "./utils";
 
 export class EvmPriceListener implements PriceListener {

pyth-evm-price-pusher/src/evm-price-listener.ts

@@ -34,11 +34,13 @@ export class PythPriceListener implements PriceListener {
 
     const priceFeeds = await this.connection.getLatestPriceFeeds(this.priceIds);
     priceFeeds?.forEach((priceFeed) => {
-      const latestAvailablePrice = priceFeed.getLatestAvailablePriceUnchecked();
+      // Getting unchecked because although it might be old
+      // but might not be there on the target chain.
+      const latestAvailablePrice = priceFeed.getPriceUnchecked();
       this.latestPriceInfo.set(priceFeed.id, {
-        price: latestAvailablePrice[0].price,
-        conf: latestAvailablePrice[0].conf,
-        publishTime: latestAvailablePrice[1],
+        price: latestAvailablePrice.price,
+        conf: latestAvailablePrice.conf,
+        publishTime: latestAvailablePrice.publishTime,
       });
     });
   }
@@ -50,15 +52,16 @@ export class PythPriceListener implements PriceListener {
       )} ${priceFeed.id}`
     );
 
-    const currentPrice = priceFeed.getCurrentPrice();
+    // Consider price to be currently available if it is not older than 60s
+    const currentPrice = priceFeed.getPriceNoOlderThan(60);
     if (currentPrice === undefined) {
       return;
     }
 
     const priceInfo: PriceInfo = {
       conf: currentPrice.conf,
       price: currentPrice.price,
-      publishTime: priceFeed.publishTime,
+      publishTime: currentPrice.publishTime,
     };
 
     this.latestPriceInfo.set(priceFeed.id, priceInfo);

pyth-evm-price-pusher/src/pyth-price-listener.ts

@@ -1,4 +1,4 @@
-import { HexString, PriceStatus } from "@pythnetwork/pyth-evm-js";
+import { HexString } from "@pythnetwork/pyth-evm-js";
 
 export type PctNumber = number;
 export type DurationInSeconds = number;
@@ -21,21 +21,6 @@ export function addLeading0x(id: HexString): HexString {
   return "0x" + id;
 }
 
-export function statusNumberToEnum(status: number): PriceStatus {
-  switch (status) {
-    case 0:
-      return PriceStatus.Unknown;
-    case 1:
-      return PriceStatus.Trading;
-    case 2:
-      return PriceStatus.Halted;
-    case 3:
-      return PriceStatus.Auction;
-    default:
-      throw new Error("Invalid status");
-  }
-}
-
 export function isWsEndpoint(endpoint: string): boolean {
   const url = new URL(endpoint);
   const protocol = url.protocol;