[FIX] Fix mypy errors.

Author: zorhay

src/xdist/scheduler/singlecollect.py

@@ -12,12 +12,12 @@
 
 class SingleCollectScheduling:
     """Implement scheduling with a single test collection phase.
-    
+
     This differs from LoadScheduling by:
     1. Only collecting tests on the first node
     2. Skipping collection on other nodes
     3. Not checking for collection equality
-    
+
     This can significantly improve startup time by avoiding redundant collection
     and collection verification across multiple worker processes.
     """
@@ -72,7 +72,7 @@ def add_node(self, node: WorkerController) -> None:
         """Add a new node to the scheduler."""
         assert node not in self.node2pending
         self.node2pending[node] = []
-        
+
         # Remember the first node as our collector
         if self.first_node is None:
             self.first_node = node
@@ -92,10 +92,10 @@ def add_node_collection(
             self.log(f"Ignoring collection from node {node.gateway.id}")
 
     def mark_test_complete(
-        self, node: WorkerController, item_index: int, duration: float = 0
+        self, node: WorkerController, item_index: int | str, duration: float = 0
     ) -> None:
         """Mark test item as completed by node."""
-        self.node2pending[node].remove(item_index)
+        self.node2pending[node].remove(int(item_index) if isinstance(item_index, str) else item_index)
         self.check_schedule(node, duration=duration)
 
     def mark_test_pending(self, item: str) -> None:
@@ -145,11 +145,11 @@ def check_schedule(self, node: WorkerController, duration: float = 0) -> None:
     def remove_node(self, node: WorkerController) -> str | None:
         """Remove a node from the scheduler."""
         pending = self.node2pending.pop(node)
-        
+
         # If this is the first node (collector), reset it
         if node == self.first_node:
             self.first_node = None
-            
+
         if not pending:
             return None
 

testing/acceptance_test.py

@@ -60,11 +60,10 @@ def test_singlecollect_handles_fixtures(self, pytester: pytest.Pytester) -> None
         pytester.makepyfile(
             """
             import pytest
-            
+
             @pytest.fixture
             def my_fixture():
                 return 42
-                
             def test_with_fixture(my_fixture):
                 assert my_fixture == 42
             """

testing/test_dsession.py

@@ -544,7 +544,7 @@ def test_handle_node_failure(self, pytester: pytest.Pytester) -> None:
         sched.mark_test_complete(node1, test_idx)
 
         # Now remove node2 (simulating failure)
-        crashitem = sched.remove_node(node2)
+        sched.remove_node(node2)
 
         # Tests assigned to node2 should go back to pending
         assert len(sched.pending) > 0
@@ -590,6 +590,7 @@ def test_first_node_failure(self, pytester: pytest.Pytester) -> None:
         # Add a new node, it should become the collector
         node3 = MockNode()
         sched.add_node(node3)
+        # Verify the new node became the collector
         assert sched.first_node == node3
 
         # Complete collection with node3