Skip to content

Modernize/improve various development things #595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
7 tasks
The-Compiler opened this issue Mar 21, 2025 · 2 comments
Open
7 tasks

Modernize/improve various development things #595

The-Compiler opened this issue Mar 21, 2025 · 2 comments

Comments

@The-Compiler
Copy link
Member

I noticed a couple of things while picking up work on pytest-qt again:

  • One test uses tmpdir instead of tmp_path
  • All tests use testdir instead of pytester
  • We might want to switch from autoflake/pyupgrade/black/flake8 to ruff?
  • We should switch from setup.py to a pyproject.toml (and maybe uv?)
  • License PyPI classifiers are deprected, we should use a SPDX license
  • We should force colored pytest output on GitHub Actions
  • We should have type annotations and use mypy on CI (and then probably add py.typed too)

Thoughts? We should probably split this into more bite-sized issues, just writing down what went through my head before I forget everything again.

@nicoddemus
Copy link
Member

nicoddemus commented Mar 21, 2025

Thanks!

We might want to switch from autoflake/pyupgrade/black/flake8 to ruff?

Seems sensible to follow pytest's lead here.

We should have type annotations and use mypy on CI (and then probably add py.typed too)

I would love that, but I recall some effort in that direction in the past, and at the time we hit some problems due to qt_compat, as the actual classes change at import time. But we should give it a go again.

Other than the above, all sound good to me.

just writing down what went through my head before I forget everything again.

Sure thing, that's great.

We should probably split this into more bite-sized issues

Not sure we need, I would be perfectly OK with PRs that solve one or more of those issues (in separate commits of course). We then close this issue when the last item of that list is checked.

On the other hand it might be a good opportunity to use that new "Create sub-issue" button. 😁

@The-Compiler
Copy link
Member Author

One more: master -> main 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants