zipfile.ZipFile does not create file in fake file system on Windows with Python 2.7.9

[borismod]

I am using zipfile package for creating zip file. The below test fails. Is there any way to make it work?

import os
import zipfile
from pyfakefs import fake_filesystem_unittest


class TestPackageBuilder(fake_filesystem_unittest.TestCase):
    def setUp(self):
        self.setUpPyfakefs()

    def test_zip(self):
        self.fs.CreateFile(u'C:\\work\\readme.txt', contents='')
        zip_file_path = os.path.join(u'c:\\work', 'some_file.zip')
        with zipfile.ZipFile(zip_file_path, 'w') as zip_file:
            zip_file.write(u'C:\\work\\readme.txt')

        self.assertFileExists(u'c:\\work\\some_file.zip')

    def assertFileExists(self, file_path):
        self.assertTrue(os.path.exists(file_path), msg='File {0} does not exist'.format(file_path))

[mrbean-bremen]

This may be an issue with case-sensitivity, which is fixed in the master branch, but not yet in the PyPi package. Try to use the same case everywhere (there is both 'C:' and 'c:' used), or try to install the master branch:
pip install -U https://github.com/jmcgeheeiv/pyfakefs/archive/master.zip
and check if it works.

[borismod]

Still fails with master and with same case:

    def test_zip(self):
        self.fs.CreateFile(u'c:\\work\\readme.txt', contents='')
        zip_file_path = os.path.join(u'c:\\work', 'some_file.zip')
        with zipfile.ZipFile(zip_file_path, 'w') as zip_file:
            zip_file.write(u'c:\\work\\readme.txt')

        self.assertFileExists(u'c:\\work\\some_file.zip')

[mrbean-bremen]

That's strange... I just tried it locally (with the master branch) and it works fine for me (both versions).

[borismod]

I am running on Win10, Pyton 2.7 if it matters

[mrbean-bremen]

I am currently run under Python 2.7 and Windows 7 (at work), which should not matter, but I may test it at Windows 10 at home in the evening. Do you use a specific test runner or environment?

[borismod]

Nope, I am running on PyCharm Pro 5.0.4, which should not matter

[mrbean-bremen]

Ok, I use PyCharm, too - I may have a look at it at later under Windows 10. No more ideas at the moment.

[mrbean-bremen]

Ok, same result:

package_test.py:

import unittest
...
<your test code>

if __name__ == '__main__':
    unittest.main()

Gives:

Microsoft Windows [Version 10.0.10586]

C:\dev\test>python --version
Python 2.7.11

C:\dev\test>python package_test.py
.
----------------------------------------------------------------------
Ran 1 test in 0.003s

OK

Can you verify that it fails for you in this same setup?

[borismod]

Thanks. I'll check it on Sunday.
On May 10, 2016 9:29 PM, "mrbean-bremen" notifications@github.com wrote:

Ok, same result:

package_test.py:

import unittest
...

if name == 'main':
unittest.main()

Gives:

Microsoft Windows [Version 10.0.10586]

C:\dev\test>python --version
Python 2.7.11

C:\dev\test>python package_test.py

.

Ran 1 test in 0.003s

OK

Van you verify that it fails for you in this same setup?

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#103 (comment)

[borismod]

I fixed the case sensitivity issue in my tests and also installed the master.zip. Still fails. The strange thing is that the an actual zip file is created in the real file system and os.walk on the Fake FS returns only the text file. Here is my code:

import os
import zipfile
from pyfakefs import fake_filesystem_unittest


class TestPackageBuilder(fake_filesystem_unittest.TestCase):
    def setUp(self):
        self.setUpPyfakefs()

    def test_zip(self):
        self.fs.CreateFile('c:\\work\\readme.txt', contents='content')
        with zipfile.ZipFile('c:\\work\\some_file.zip', 'w') as zip_file:
            zip_file.write('c:\\work\\readme.txt')

        for f in os.walk('c:\\work'):
            print f

        self.assertFileExists('c:\\work\\some_file.zip')

    def assertFileExists(self, file_path):
        self.assertTrue(os.path.exists(file_path), msg='File {0} does not exist'.format(file_path))

[mrbean-bremen]

Ok, sounds like zipfile doesn't use the fake filesystem for some reason. I just tried your version on the command line (adding import unittest and main, as shown above), and the output is:

C:\...\test>python package_test.py
('c:\\work', [], ['readme.txt', 'some_file.zip'])
.
----------------------------------------------------------------------
Ran 1 test in 0.031s
OK

Are you sure there is no other code involved? Have you tried the bare command line test?

[borismod]

Fails also from the command line:

[mrbean-bremen]

Ok, I'm at loss here. zipfile uses open(), and that should be stubbed out to use fake_filesystem.FakeFileOpen, which it does for me. Maybe jmcgeheeiv (the owner of pyfakefs) has an idea, I cannot think of something at the moment... I guess you are using the latest Python 2.7 (just to be sure to have the same zipfile implementation).

[borismod]

OMG, upgrading from Python 2.7.9 to 2.7.10 fixed the problem.

Thanks a lot for your patience!

[mrbean-bremen]

Didn't expect it, but well - you are welcome!