Changed method names to be PEP 8 conform

Author: mrbean-bremen

CHANGES.md

@@ -6,7 +6,7 @@ The release versions are PyPi releases.
 #### New Features
   * Added new methods to `fake_filesystem.FakeFilesystem` that make real files 
     and directories appear within the fake file system: 
-    `AddRealFile()`, `AddRealDirectory()` and `AddRealPaths()`.
+    `add_real_file()`, `add_real_directory()` and `add_real_paths()`.
     File contents are read from the real file system only when needed.
   * Added the CHANGES.md release notes to the release manifest
 

example_test.py

@@ -145,12 +145,12 @@ def test_scandir(self):
         self.assertTrue(entries[2].is_file())
 
     def test_real_file_access(self):
-        """Test `example.file_contents()` for a real file after adding it using `AddRealFile()`."""
+        """Test `example.file_contents()` for a real file after adding it using `add_real_file()`."""
         real_file = __file__
         with REAL_OPEN(real_file, 'rb') as f:
             real_contents = f.read()
         self.assertRaises(IOError, example.file_contents, real_file)
-        self.fs.AddRealFile(real_file)
+        self.fs.add_real_file(real_file)
         self.assertEqual(example.file_contents(real_file), real_contents)
 
 

fake_filesystem_test.py

@@ -4452,23 +4452,23 @@ def setUp(self):
 
     def testAddNonExistingRealFileRaises(self):
         nonexisting_path = os.path.join('nonexisting', 'test.txt')
-        self.assertRaises(OSError, self.filesystem.AddRealFile, nonexisting_path)
+        self.assertRaises(OSError, self.filesystem.add_real_file, nonexisting_path)
         self.assertFalse(self.filesystem.Exists(nonexisting_path))
 
     def testAddNonExistingRealDirectoryRaises(self):
         nonexisting_path = '/nonexisting'
-        self.assertRaisesIOError(errno.ENOENT, self.filesystem.AddRealDirectory, nonexisting_path)
+        self.assertRaisesIOError(errno.ENOENT, self.filesystem.add_real_directory, nonexisting_path)
         self.assertFalse(self.filesystem.Exists(nonexisting_path))
 
     def testExistingFakeFileRaises(self):
         real_file_path = __file__
         self.filesystem.CreateFile(real_file_path)
-        self.assertRaisesIOError(errno.EEXIST, self.filesystem.AddRealFile, real_file_path)
+        self.assertRaisesIOError(errno.EEXIST, self.filesystem.add_real_file, real_file_path)
 
     def testExistingFakeDirectoryRaises(self):
         real_dir_path = os.path.dirname(__file__)
         self.filesystem.CreateDirectory(real_dir_path)
-        self.assertRaisesOSError(errno.EEXIST, self.filesystem.AddRealDirectory, real_dir_path)
+        self.assertRaisesOSError(errno.EEXIST, self.filesystem.add_real_directory, real_dir_path)
 
     def checkFakeFileStat(self, fake_file, real_file_path):
         self.assertTrue(self.filesystem.Exists(real_file_path))
@@ -4502,22 +4502,22 @@ def checkWritableFile(self, fake_file, real_file_path):
 
     def testAddExistingRealFileReadOnly(self):
         real_file_path = __file__
-        fake_file = self.filesystem.AddRealFile(real_file_path)
+        fake_file = self.filesystem.add_real_file(real_file_path)
         self.checkFakeFileStat(fake_file, real_file_path)
         self.assertEqual(fake_file.st_mode & 0o333, 0)
         self.checkReadOnlyFile(fake_file, real_file_path)
 
     def testAddExistingRealFileReadWrite(self):
         real_file_path = os.path.realpath(__file__)
-        fake_file = self.filesystem.AddRealFile(real_file_path, read_only=False)
+        fake_file = self.filesystem.add_real_file(real_file_path, read_only=False)
 
         self.checkFakeFileStat(fake_file, real_file_path)
         self.assertEqual(fake_file.st_mode, os.stat(real_file_path).st_mode)
         self.checkWritableFile(fake_file, real_file_path)
 
     def testAddExistingRealDirectoryReadOnly(self):
         real_dir_path = os.path.join(os.path.dirname(__file__), 'pyfakefs')
-        fake_dir = self.filesystem.AddRealDirectory(real_dir_path)
+        fake_dir = self.filesystem.add_real_directory(real_dir_path)
         self.assertTrue(self.filesystem.Exists(real_dir_path))
         self.assertTrue(self.filesystem.Exists(os.path.join(real_dir_path, 'fake_filesystem.py')))
         self.assertTrue(self.filesystem.Exists(os.path.join(real_dir_path, 'fake_pathlib.py')))
@@ -4529,14 +4529,14 @@ def testAddExistingRealDirectoryReadOnly(self):
 
     def testAddExistingRealDirectoryTree(self):
         real_dir_path = os.path.dirname(__file__)
-        self.filesystem.AddRealDirectory(real_dir_path)
+        self.filesystem.add_real_directory(real_dir_path)
         self.assertTrue(self.filesystem.Exists(os.path.join(real_dir_path, 'fake_filesystem_test.py')))
         self.assertTrue(self.filesystem.Exists(os.path.join(real_dir_path, 'pyfakefs', 'fake_filesystem.py')))
         self.assertTrue(self.filesystem.Exists(os.path.join(real_dir_path, 'pyfakefs', '__init__.py')))
 
     def testAddExistingRealDirectoryReadWrite(self):
         real_dir_path = os.path.join(os.path.dirname(__file__), 'pyfakefs')
-        self.filesystem.AddRealDirectory(real_dir_path, read_only=False)
+        self.filesystem.add_real_directory(real_dir_path, read_only=False)
         self.assertTrue(self.filesystem.Exists(real_dir_path))
         self.assertTrue(self.filesystem.Exists(os.path.join(real_dir_path, 'fake_filesystem.py')))
         self.assertTrue(self.filesystem.Exists(os.path.join(real_dir_path, 'fake_pathlib.py')))
@@ -4549,7 +4549,7 @@ def testAddExistingRealDirectoryReadWrite(self):
     def testAddExistingRealPathsReadOnly(self):
         real_file_path = os.path.realpath(__file__)
         real_dir_path = os.path.join(os.path.dirname(__file__), 'pyfakefs')
-        self.filesystem.AddRealPaths([real_file_path, real_dir_path])
+        self.filesystem.add_real_paths([real_file_path, real_dir_path])
 
         fake_file = self.filesystem.ResolveObject(real_file_path)
         self.checkFakeFileStat(fake_file, real_file_path)
@@ -4563,7 +4563,7 @@ def testAddExistingRealPathsReadOnly(self):
     def testAddExistingRealPathsReadWrite(self):
         real_file_path = os.path.realpath(__file__)
         real_dir_path = os.path.join(os.path.dirname(__file__), 'pyfakefs')
-        self.filesystem.AddRealPaths([real_file_path, real_dir_path], read_only=False)
+        self.filesystem.add_real_paths([real_file_path, real_dir_path], read_only=False)
 
         fake_file = self.filesystem.ResolveObject(real_file_path)
         self.checkFakeFileStat(fake_file, real_file_path)

pyfakefs/fake_filesystem.py

@@ -210,7 +210,7 @@ def __init__(self, name, st_mode=stat.S_IFREG | PERM_DEF_FILE,
         self.st_uid = None
         self.st_gid = None
 
-        # members changed only by _CreateFile() to implement AddRealFile()
+        # members changed only by _CreateFile() to implement add_real_file()
         self.read_from_real_fs = False
         self.file_path = None
 
@@ -1618,7 +1618,7 @@ def CreateFile(self, file_path, st_mode=stat.S_IFREG | PERM_DEF_FILE,
         """
         return self._CreateFile(file_path, st_mode, contents, st_size, create_missing_dirs, apply_umask, encoding)
 
-    def AddRealFile(self, file_path, read_only=True):
+    def add_real_file(self, file_path, read_only=True):
         """Create file_path, including all the parent directories along the way, for a file
         existing in the real file system without reading the contents, which will be read on demand.
         New in pyfakefs 3.2.
@@ -1641,7 +1641,7 @@ def AddRealFile(self, file_path, read_only=True):
         return self._CreateFile(file_path, contents=None, read_from_real_fs=True,
                                 st_mode=mode, real_stat=real_stat)
 
-    def AddRealDirectory(self, dir_path, read_only=True):
+    def add_real_directory(self, dir_path, read_only=True):
         """Create fake directory for the existing directory at path, and entries for all contained
         files in the real file system.
         New in pyfakefs 3.2.
@@ -1664,11 +1664,11 @@ def AddRealDirectory(self, dir_path, read_only=True):
         self.CreateDirectory(dir_path)
         for base, _, files in os.walk(dir_path):
             for fileEntry in files:
-                self.AddRealFile(os.path.join(base, fileEntry), read_only)
+                self.add_real_file(os.path.join(base, fileEntry), read_only)
 
-    def AddRealPaths(self, path_list, read_only=True):
+    def add_real_paths(self, path_list, read_only=True):
         """Convenience method to add several files and directories from the real file system
-        in the fake file system. See `AddRealFile()` and `AddRealDirectory()`.
+        in the fake file system. See `add_real_file()` and `add_real_directory()`.
         New in pyfakefs 3.2.
 
         Args:
@@ -1683,9 +1683,9 @@ def AddRealPaths(self, path_list, read_only=True):
         """
         for path in path_list:
             if os.path.isdir(path):
-                self.AddRealDirectory(path, read_only)
+                self.add_real_directory(path, read_only)
             else:
-                self.AddRealFile(path, read_only)
+                self.add_real_file(path, read_only)
 
     def _CreateFile(self, file_path, st_mode=stat.S_IFREG | PERM_DEF_FILE,
                     contents='', st_size=None, create_missing_dirs=True,