Skip to content

Commit dbd5d10

Browse files
committed
fix: wait for the server to be done
without this fix I was running into errors running benchmarks back-to-back, I believe because the first benchmark run wouldn't shut down and release the port in time
1 parent 8db7411 commit dbd5d10

File tree

4 files changed

+4
-0
lines changed

4 files changed

+4
-0
lines changed

benchmarks/aiohttp.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@
3535

3636
finally:
3737
p.terminate()
38+
p.wait()
3839

3940
if len(sys.argv) > 2:
4041
json.dump(times, open(sys.argv[2], 'w'))

benchmarks/djangocms.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -79,6 +79,7 @@ def runbenchmark(n=800, out_file=None):
7979

8080
finally:
8181
p.terminate()
82+
p.wait()
8283

8384
if __name__ == "__main__":
8485
exe = sys.executable

benchmarks/flaskblogging.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@
3535

3636
finally:
3737
p.terminate()
38+
p.wait()
3839

3940
if len(sys.argv) > 2:
4041
json.dump(times, open(sys.argv[2], 'w'))

benchmarks/gunicorn.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@
3535

3636
finally:
3737
p.terminate()
38+
p.wait()
3839

3940
if len(sys.argv) > 2:
4041
json.dump(times, open(sys.argv[2], 'w'))

0 commit comments

Comments
 (0)