Why not providing url to last img instead of last image name in cameras endpoint ?

[fe51]

Hi there,

Currently, in cameras endpoint, fetching all cameras for a given scope, for each camera, last_image is provided as the name fo the last_image file (on the bucket)

Why not providing directly the url to the image (on the bucket/s3) ? because currently, it is not possible to resolve this url + it implies multiple requests that seems not relevant (it would imply a request to the url of each last image cam for each camera)

It would be great if in when requesting cameras, I could use all info to build camera status page (that display last image) --> Currently, we've thought the last image would be the url to access the file.

What do you think ? @frgfm @RonanMorgan @MateoLostanlen

Happy to discuss it !

[frgfm]

Thanks for asking!
Up until now, it was mostly for server load. We do process a LOT of detections per day, and resolving a public URL isn't instant. However, on another project, I've done this exactly (returning the temporary URL) and it works, but I don't have to resolve that many.

We're gonna need to check it doesn't blow up past the timeout: both for the S3 operation itself (can be checked with localstack), but also for the latency between storage and our API instance (can't check locally)

[frgfm]

My bad, I was thinking about 1 url /detection but here we're talking about 1 url / camera, that should be alright! I'll implement this

[MateoLostanlen]

Hey,

Okay, I get the idea. Honestly, it’s important to keep it for detections to maintain the current speed, but for the last_image, we don’t need it as much

We use it for the camera status page, so it’s not a big deal if we have to make one call per camera when loading the page, even if it’s not optimal

Or maybe the solution could be a single call to fetch url for all the cameras of a user? Like a route that returns everything. Do you think that’s doable ?

[frgfm]

I think that was the point of @fe51 :) I'll implement this shortly

[frgfm]

This is solved in #475 😃