Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inspector "Project Removed" Indicator Can Be Inaccurate #111

Open
import-pandas-as-numpy opened this issue May 7, 2023 · 2 comments
Open

Comments

@import-pandas-as-numpy
Copy link
Contributor

REF: #110

Problem: Inspector can serve a 'Project Removed' response when a package has not yet been removed.

Background: When a package is uploaded, in our experience, it can often take a moment for PyPI to serve the appropriate content on the package's page, while Inspector is able to serve the contents of the files relatively immediately.

Steps to Reproduce:

  1. Identify a recently uploaded package.
  2. Visit the inspector link of said package prior to the content being served on PyPI.

Example:
We were alerted to pipcryptov2 at 2:46PM.
I visited the Inspector URL to confirm malicious content. I was met with a package removed notification.
image
The PyPI page initially 404'd, but refreshing it moments later provided the appropriate webpage, and the package had not yet been removed.
image

Discussion: I understand this is probably a transient issue and likely not impactful as a whole to the service, as very few people are visiting inspector within the time frame that a package is uploaded and the time the PyPI content is served. Given that we tend to respond within ~60 seconds of receiving notification of a package upload, this is likely an issue that will only affect our service and services similar, so from our end, we can inform our team accurately that this should be ignored unless responding to a package significantly after the fact.

@miketheman
Copy link
Member

Can I ask if someone tried to actually install this removed package in the interim?
I wonder if it has something to do with caching of the webpage, but not the installation response.

@import-pandas-as-numpy
Copy link
Contributor Author

import-pandas-as-numpy commented May 8, 2023

Can I ask if someone tried to actually install this removed package in the interim? I wonder if it has something to do with caching of the webpage, but not the installation response.

We pulled the package down from PyPI through the download link (not through pip) prior to. It is how we scanned the file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants