-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement PEP 753: "Well-known Project URLs in Metadata" #13135
Comments
Thanks for pinging me @ichard26!
Indeed 🙂 -- |
Hmm, I was under the impression that there may be some work on pip's end because pip does consume and show project URLs. I included a link to the code in the issue description. Is that logic PEP compliant? |
Ah yeah, my bad -- I forgot that we relaxed the language in the PEP to be any metadata consumer, not just indices. The current logic looks like it needs to be updated (as does PyPI's -- I haven't done that yet). The PEP's label normalization logic is here: https://peps.python.org/pep-0753/#label-normalization. That should result in a strict superset of results as the current normalization logic. |
Ah, that seems very easy. I'll put this on my to-do list, but of course, no promises I'll get to it. And definitely not soon... Thanks for confirming my suspicions! |
No problem, sorry for the false lead! FWIW, this spurred me into doing the first bits on Warehouse as well: pypi/warehouse#17470 |
A few months ago, PEP 753 was accepted. It is now known as the "Well-known Project URLs in Metadata" standard. We should implement it as pip does consume project URL metadata.
I haven't looked at pip's existing
Project-URL
orHome-page
handling, so it's possible that there is very little or nothing to do on pip's end, but I wanted to file this issue to make sure we take a look at some point. The logic that mirrors PyPI's old homepage Project-URL aliasing probably needs a some tweaking to have it conform to the specification.pip/src/pip/_internal/commands/show.py
Lines 134 to 146 in f8f0f5a
cc @woodruffw
The text was updated successfully, but these errors were encountered: