Skip to content

Commit 9ab9315

Browse files
authored
Merge pull request #374 from pymzml/fu-patch-1
Update version.txt
2 parents aaa19ea + 637cbb2 commit 9ab9315

File tree

5 files changed

+20
-19
lines changed

5 files changed

+20
-19
lines changed

pymzml/regex_patterns.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
"""Collection of regular expressions to catch spectrum XML-tags."""
2+
23
import re
34
import regex
45

pymzml/run.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ def __init__(
8484
build_index_from_scratch=False,
8585
skip_chromatogram=True,
8686
index_regex=None,
87-
**kwargs
87+
**kwargs,
8888
):
8989
"""Initialize and set required attributes."""
9090
self.index_regex = index_regex
@@ -296,7 +296,7 @@ def _obo_version_validator(version):
296296
2018: "4.1.10",
297297
2019: "4.1.22",
298298
2024: "4.1.79",
299-
2025: "4.1.188"
299+
2025: "4.1.188",
300300
}
301301
version_fixed = None
302302
if obo_rgx.match(version):
@@ -406,8 +406,8 @@ def _init_iter(self):
406406
self.info["data_processing_list"] = True
407407
self.info["data_processing_list_element"] = element
408408
elif element.tag.endswith("}cvParam"):
409-
if self.term_is_a_member(element.attrib.get('accession'), "MS:1000494"):
410-
self.info["instrument_name"] = element.attrib.get('name')
409+
if self.term_is_a_member(element.attrib.get("accession"), "MS:1000494"):
410+
self.info["instrument_name"] = element.attrib.get("name")
411411

412412
elif element.tag.endswith("}spectrumList"):
413413
spec_cnt = element.attrib.get("count")
@@ -470,9 +470,9 @@ def term_is_a_member(self, tested_term, member_of_term):
470470
try:
471471
term_in = self.OT[tested_term]
472472
if term_in:
473-
is_member = self.OT.id[tested_term]['is_a'].startswith(member_of_term)
473+
is_member = self.OT.id[tested_term]["is_a"].startswith(member_of_term)
474474
except KeyError:
475-
print(f'term not found ({tested_term})')
475+
print(f"term not found ({tested_term})")
476476
return is_member
477477

478478

pymzml/utils/GSGW.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -256,7 +256,7 @@ def _write_identifier(self, identifier):
256256
Arguments:
257257
identifier (str or int): identifier to write into index
258258
"""
259-
id_format = "{0:\xAC>" + str(self.max_idx_len) + "}"
259+
id_format = "{0:\xac>" + str(self.max_idx_len) + "}"
260260
identifier = str(identifier)
261261
identifier = id_format.format(identifier).encode("latin-1")
262262
self.file_out.write(identifier)
@@ -270,7 +270,7 @@ def _write_offset(self, offset):
270270
offset (int): offset which will be formatted and written
271271
into file index
272272
"""
273-
offset_format = "{0:\xAC>" + str(self.max_offset_len) + "}"
273+
offset_format = "{0:\xac>" + str(self.max_offset_len) + "}"
274274
offset = str(offset)
275275
offset = offset_format.format(offset).encode("latin-1")
276276
self.file_out.write(offset)

pymzml/version.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
2.5.10
1+
2.5.11

tests/main_reader_test.py

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ def setUp(self):
3030
self.reader_uncompressed_unindexed = run.Reader(file_uncompressed_unindexed)
3131
self.reader_bad_obo_version = run.Reader(file_bad_obo_version)
3232
self.reader_set_obo_version = run.Reader(
33-
file_bad_obo_version, obo_version="3.25.0"
33+
file_bad_obo_version, obo_version="4.1.79"
3434
)
3535
self.reader_set_year_obo_version = run.Reader(
3636
file_uncompressed_indexed, obo_version="23:06:2017"
@@ -76,7 +76,7 @@ def test_init_iter(self):
7676
run_id = self.reader_uncompressed_unindexed.info["run_id"]
7777
start_time = self.reader_uncompressed_unindexed.info["start_time"]
7878
self.assertEqual(mzml_version, "1.1.0")
79-
self.assertEqual(obo_version, "3.25.0")
79+
self.assertEqual(obo_version, "4.1.79")
8080
self.assertIsInstance(spec_count, int)
8181
self.assertEqual(run_id, "exp105-01-ds5562-Pos")
8282
self.assertEqual(start_time, "2013-09-10T10:31:08Z")
@@ -87,7 +87,7 @@ def test_init_iter(self):
8787
run_id = self.reader_uncompressed_unindexed.info["run_id"]
8888
start_time = self.reader_uncompressed_unindexed.info["start_time"]
8989
self.assertEqual(mzml_version, "1.1.0")
90-
self.assertEqual(obo_version, "3.25.0")
90+
self.assertEqual(obo_version, "4.1.79")
9191
self.assertIsInstance(spec_count, int)
9292
self.assertEqual(run_id, "exp105-01-ds5562-Pos")
9393
self.assertEqual(start_time, "2013-09-10T10:31:08Z")
@@ -98,7 +98,7 @@ def test_init_iter(self):
9898
run_id = self.reader_uncompressed_unindexed.info["run_id"]
9999
start_time = self.reader_uncompressed_unindexed.info["start_time"]
100100
self.assertEqual(mzml_version, "1.1.0")
101-
self.assertEqual(obo_version, "3.25.0")
101+
self.assertEqual(obo_version, "4.1.79")
102102
self.assertIsInstance(spec_count, int)
103103
self.assertEqual(run_id, "exp105-01-ds5562-Pos")
104104
self.assertEqual(start_time, "2013-09-10T10:31:08Z")
@@ -110,7 +110,7 @@ def test_init_iter(self):
110110
start_time = self.reader_uncompressed_unindexed.info["start_time"]
111111

112112
self.assertEqual(mzml_version, "1.1.0")
113-
self.assertEqual(obo_version, "3.25.0")
113+
self.assertEqual(obo_version, "4.1.79")
114114
self.assertIsInstance(spec_count, int)
115115
self.assertEqual(run_id, "exp105-01-ds5562-Pos")
116116
self.assertEqual(start_time, "2013-09-10T10:31:08Z")
@@ -122,8 +122,8 @@ def test_init_iter(self):
122122
start_time = self.reader_bad_obo_version.info["start_time"]
123123

124124
self.assertEqual(mzml_version, "1.1.0")
125-
# run._obo_version_validator 2017 default obo = 4.1.0
126-
self.assertEqual(obo_version, "4.1.0")
125+
# run._obo_version_validator 2017 default obo = 4.1.79
126+
self.assertEqual(obo_version, "4.1.79")
127127
self.assertIsInstance(spec_count, int)
128128
self.assertEqual(run_id, "exp105-01-ds5562-Pos")
129129
self.assertEqual(start_time, "2013-09-10T10:31:08Z")
@@ -135,7 +135,7 @@ def test_init_iter(self):
135135
start_time = self.reader_set_obo_version.info["start_time"]
136136

137137
self.assertEqual(mzml_version, "1.1.0")
138-
self.assertEqual(obo_version, "3.25.0")
138+
self.assertEqual(obo_version, "4.1.79")
139139
self.assertIsInstance(spec_count, int)
140140
self.assertEqual(run_id, "exp105-01-ds5562-Pos")
141141
self.assertEqual(start_time, "2013-09-10T10:31:08Z")
@@ -147,7 +147,7 @@ def test_init_iter(self):
147147
start_time = self.reader_set_year_obo_version.info["start_time"]
148148

149149
self.assertEqual(mzml_version, "1.1.0")
150-
# run._obo_version_validator 2017 default obo = 4.1.0
150+
# run._obo_version_validator 2017 default obo = 4.1.79
151151
self.assertEqual(obo_version, "4.1.0")
152152
self.assertIsInstance(spec_count, int)
153153
self.assertEqual(run_id, "exp105-01-ds5562-Pos")
@@ -174,7 +174,7 @@ def test_init_iter(self):
174174

175175
self.assertEqual(mzml_version, "1.1.0")
176176
# run._obo_version_validator set invalid obo = 1.1.0
177-
self.assertEqual(obo_version, "1.1.0")
177+
self.assertEqual(obo_version, "4.1.79")
178178
self.assertIsInstance(spec_count, int)
179179
self.assertEqual(run_id, "exp105-01-ds5562-Pos")
180180
self.assertEqual(start_time, "2013-09-10T10:31:08Z")

0 commit comments

Comments
 (0)