Remove python2 compatibility code (#564)

* Remove Python2 checks
Remove Python2 code snippets

* Fix smaller errors
 Remove Python2 from checks, CI stuff and more

* Fix missing imports
Add missing closing braket

* Remve pypy2 from CI

* Should fix unawaited coroutines which may cause CI to timeout

* replace old coroutine style

Co-authored-by: dhoomakethu <[email protected]>

Author: swamper123

.github/pythonpackage.yml

@@ -15,12 +15,12 @@ jobs:
         python-version: '3.x'
     - name: Install dependencies
       run: |
-        python -m pip install --upgrade pip
+        python3 -m pip install --upgrade pip
         pip install setuptools wheel twine
     - name: Build and publish
       env:
         TWINE_USERNAME: ${{ secrets.PYPI_USERNAME }}
         TWINE_PASSWORD: ${{ secrets.PYPI_PASSWORD }}
       run: |
-        python setup.py sdist bdist_wheel
+        python3 setup.py sdist bdist_wheel
         twine upload dist/*

.github/workflows/ci.yml

@@ -37,7 +37,6 @@ jobs:
               3.7: docker://python:3.7-buster
               3.8: docker://python:3.8-buster
               3.9: docker://python:3.9-buster
-              pypy2: docker://pypy:2-jessie
               pypy3: docker://pypy:3-stretch
           - name: macOS
             runs-on: macos-latest

CHANGELOG.rst

@@ -14,7 +14,6 @@ version 3.0.0dev1
 * Fix for lazy loading serial module with asyncio clients.
 * Updated examples and tests
 
-
 version 3.0.0dev0
 ----------------------------------------------------------
 * Support python3.7 and above

Makefile

@@ -41,22 +41,12 @@ check: install
 
 test: install
 	@pip install --upgrade --quiet --requirement=requirements-tests.txt
-ifeq ($(PYVER),3.6)
-	$(info Running tests on $(PYVER))
-	@pip install --upgrade pip --quiet
-	@pytest --cov=pymodbus/ --cov-report term-missing  test/test_server_asyncio.py test
-	@coverage report --fail-under=85 -i
-else ifeq ($(PYVER),2.7)
-	$(info Running tests on $(PYVER))
-	@pip install pip==20.3.4 --quiet
-	@pytest --cov-config=.coveragerc --cov=pymodbus/ --cov-report term-missing --ignore test/test_server_asyncio.py --ignore test/test_client_async_asyncio.py test
-	@coverage report --fail-under=90 -i
-else
-	$(info Running tests on $(PYVER))
-	@pip install --upgrade pip --quiet
-	@pytest --cov=pymodbus/ --cov-report term-missing  test
-	@coverage report --fail-under=85 -i
-endif
+
+    $(info Running tests on $(PYVER))
+    @pip install --upgrade pip --quiet
+    @pytest --cov=pymodbus/ --cov-report term-missing  test
+    @coverage report --fail-under=85 -i
+
 
 tox: install
 	@pip install --upgrade --quiet tox && tox

README.rst

@@ -23,7 +23,7 @@ Summary
 Pymodbus is a full Modbus protocol implementation using twisted/tornado/asyncio for its
 asynchronous communications core.  It can also be used without any third
 party dependencies (aside from pyserial) if a more lightweight project is
-needed.  Furthermore, it should work fine under any python version > 2.7
+needed.  Furthermore, it should work fine under any python version >= 3.7
 (including python 3+)
 
 

doc/INSTALL

@@ -1,7 +1,7 @@
 Requirements
 -------------
 
-* Python 2.7 or later.
+* Python 3.7 or later.
 * Python Twisted, Tornado or asyncio (For async client and server)
 * Pyserial
 

doc/api/doxygen/build.py

@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python3
 '''
 Doxygen API Builder
 ---------------------
@@ -29,8 +29,8 @@ def which(program):
     return None
 
 if which('doxygen') is not None:
-    print "Building Doxygen API Documentation"
+    print("Building Doxygen API Documentation")
     os.system("doxygen .doxygen")
     if os.path.exists('../../../build'):
         shutil.move("html", "../../../build/doxygen")
-else: print "Doxygen not available...not building"
+else: print("Doxygen not available...not building")

doc/api/epydoc/build.py

@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python3
 '''
 Epydoc API Runner
 ------------------
@@ -27,12 +27,12 @@
     if not os.path.exists("./html"):
         os.mkdir("./html")
 
-    print "Building Epydoc API Documentation"
+    print( "Building Epydoc API Documentation")
     cli()
 
     if os.path.exists('../../../build'):
         shutil.move("html", "../../../build/epydoc")
-except Exception, ex:
+except Exception as ex:
     import traceback,sys
     traceback.print_exc(file=sys.stdout)
-    print "Epydoc not avaliable...not building"
+    print( "Epydoc not avaliable...not building")

doc/api/pydoc/build.py

@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python3
 """
 Pydoc sub-class for generating documentation for entire packages.
 
@@ -447,7 +447,7 @@ def recurseScan(self, objectList):
     if not os.path.exists("./html"):
         os.mkdir("./html")
 
-    print "Building Pydoc API Documentation"
+    print( "Building Pydoc API Documentation")
     PackageDocumentationGenerator(
         baseModules = ['pymodbus', '__builtin__'],
         destinationDirectory = "./html/",

doc/api/pydoctor/build.py

@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python3
 '''
 Pydoctor API Runner
 ---------------------
@@ -19,9 +19,10 @@
         --html-output=html
         --html-write-function-pages --make-html'''.split()
 
-    print "Building Pydoctor API Documentation"
+    print( "Building Pydoctor API Documentation")
     main(sys.argv[1:])
 
     if os.path.exists('../../../build'):
         shutil.move("html", "../../../build/pydoctor")
-except: print "Pydoctor unavailable...not building"
+except:
+    print( "Pydoctor unavailable...not building")