Skip to content

Commit 1bf53a3

Browse files
committed
Minor improvements
* Do `pre-commit autoupdate` * `Makefile`: * Set `PYTHONPATH` to `pwd` (instead of `.`) * `install`: depend on `requirements/dev.txt` "recipe" * Whitespace normalization * `tool.ruff.lint.pydocstyle.convention`: Hint we are actually doing `sphinx` * Fix (== ignore) errors coming from the update * Minor linguistic change Signed-off-by: Stavros Ntentos <[email protected]>
1 parent e3deae9 commit 1bf53a3

File tree

5 files changed

+322
-290
lines changed

5 files changed

+322
-290
lines changed

.pre-commit-config.yaml

+4-4
Original file line numberDiff line numberDiff line change
@@ -35,22 +35,22 @@ repos:
3535
- --offset
3636
- '2'
3737
- repo: https://github.com/astral-sh/ruff-pre-commit
38-
rev: v0.5.1
38+
rev: v0.6.8
3939
hooks:
4040
- id: ruff
4141
args:
4242
- --fix
4343
exclude: tests/input/
4444
- repo: https://github.com/psf/black
45-
rev: 24.4.2
45+
rev: 24.8.0
4646
hooks:
4747
- id: black
4848
- repo: https://github.com/asottile/blacken-docs
4949
rev: 1.18.0
5050
hooks:
5151
- id: blacken-docs
5252
additional_dependencies:
53-
- black==23.9.1
53+
- black==24.8.0
5454
- repo: https://github.com/pre-commit/pygrep-hooks
5555
rev: v1.10.0
5656
hooks:
@@ -74,7 +74,7 @@ repos:
7474
language: pygrep
7575
types: [python]
7676
- repo: https://github.com/pre-commit/mirrors-mypy
77-
rev: v1.10.1
77+
rev: v1.11.2
7878
hooks:
7979
- id: mypy
8080
exclude: tests/input/

Makefile

+3-4
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
11
# Use python executables inside venv
22
export PATH := .venv/bin:$(PATH)
3-
export PYTHONPATH=.
3+
export PYTHONPATH= `pwd`
44

55
# creates the venv
66
.venv/bin/python3.11:
77
python3.11 -m venv .venv
88

99
# makes sures the venv contains a given version of pip and pip-tools
1010
.venv: .venv/bin/python3.11
11-
pip install --quiet --upgrade 'pip==23.3.1' 'pip-tools==7.3'
11+
pip install --quiet --upgrade 'pip==24.2' 'pip-tools==7.4.1'
1212

1313
# generates a lock file with pinned version of all dependencies to be used by the CI and local devs
1414
requirements/dev.txt: .venv requirements/dev.in
@@ -30,10 +30,9 @@ upgrade: .venv
3030
pyproject.toml \
3131
requirements/dev.in
3232

33-
3433
# creates the venv if not present then install the dependencies, the package and pre-commit
3534
.PHONY: install
36-
install: .venv
35+
install: .venv requirements/dev.txt
3736
pip-sync requirements/dev.txt
3837
# install pylint_pytest (deps are already handled by the line before)
3938
pip install --no-deps -e .

pylint_pytest/checkers/variables.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,12 @@
1212

1313

1414
class CustomVariablesChecker(VariablesChecker):
15-
"""Overrides the default VariablesChecker of pylint to discard unwanted warning messages"""
15+
"""Overrides the default VariablesChecker of pylint to discard unwanted warning messages."""
1616

1717
# pylint: disable=protected-access
1818
# this class needs to access the fixture checker registries
1919

20-
def add_message(
20+
def add_message( # pylint: disable=too-many-positional-arguments # Original Signature
2121
self,
2222
msgid: str,
2323
line: int | None = None,

pyproject.toml

+2
Original file line numberDiff line numberDiff line change
@@ -166,6 +166,8 @@ ignore = [
166166
]
167167

168168
[tool.ruff.lint.pydocstyle]
169+
# https://github.com/astral-sh/ruff/pull/13286
170+
# XXX: sphinx??
169171
convention = "google"
170172

171173
[tool.ruff.lint.extend-per-file-ignores]

0 commit comments

Comments
 (0)