Skip to content

Commit fe9fa5a

Browse files
samukwekuericmjl
andauthored
[TST] Fix for Issue #1184 (#1186)
* add fix for GH#1184 * changelog * fix grammar * clearer comments * update changelog Co-authored-by: Eric Ma <[email protected]>
1 parent 32bd2ab commit fe9fa5a

File tree

2 files changed

+11
-1
lines changed

2 files changed

+11
-1
lines changed

CHANGELOG.md

+1
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@
3232
- [TST] Compat with macos and window, to fix `FailedHealthCheck` Issue #1181 @Zeroto521
3333
- [INF] Merge two docs CIs (`docs-preview.yml` and `docs.yml`) to one. And add `documentation` pytest mark. PR #1183 @Zeroto521
3434
- [INF] Merge `codecov.yml` (only works for the dev branch pushing event) into `tests.yml` (only works for PR event). PR #1185 @Zeroto521
35+
- [TST] Fix failure for test/timeseries/test_fill_missing_timestamp. Issue #1184 @samukweku
3536
- [BUG] Import `DataDescription` to fix: `AttributeError: 'DataFrame' object has no attribute 'data_description'`. PR #1191 @Zeroto521
3637

3738
## [v0.23.1] - 2022-05-03

tests/timeseries/test_fill_missing_timestamps.py

+10-1
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,16 @@ def test_fill_missing_timestamps(timeseries_dataframe):
2626
df1 = timeseries_dataframe.drop(timeseries_dataframe.index[random_number])
2727

2828
# Fill missing timestamps
29-
result = fill_missing_timestamps(df1, frequency="1H")
29+
# fix for GH#1184 is to use the start and end from
30+
# timeseries_dataframe
31+
# imagine that the last row of df1 is removed, or the first entry
32+
# the length check in the assert line will fail
33+
result = fill_missing_timestamps(
34+
df1,
35+
frequency="1H",
36+
first_time_stamp=timeseries_dataframe.index.min(),
37+
last_time_stamp=timeseries_dataframe.index.max(),
38+
)
3039

3140
# Testing if the missing timestamp has been filled
3241
assert len(result) == len(timeseries_dataframe)

0 commit comments

Comments
 (0)