Skip to content

Commit e31bac3

Browse files
authored
[BUG] address issue #1201 (#1203)
1 parent 634093f commit e31bac3

File tree

5 files changed

+11
-5
lines changed

5 files changed

+11
-5
lines changed

AUTHORS.md

+4-2
Original file line numberDiff line numberDiff line change
@@ -108,5 +108,7 @@ Contributors
108108
- [@gahjelle](https://github.com/gahjelle) | [contributions](https://github.com/pyjanitor-devs/pyjanitor/issues?q=is%3Aclosed+mentions%3Agahjelle)
109109
- [@ethompsy](https://github.com/ethompsy) | [contributions](https://github.com/pyjanitor-devs/pyjanitor/issues?q=is%3Aclosed+mentions%3Aethompsy)
110110
- [@apatao](https://github.com/apatao) | [contributions](https://github.com/pyjanitor-devs/pyjanitor/issues?q=is%3Aclosed+mentions%3Aapatao)
111-
- [@OdinTech3](https://github.com/OdinTech3) | [contributions](https://github.com/pyjanitor-devs/pyjanitor/pull/1094)
112-
- [@asmirnov69](https://github.com/asmirnov69) | [contributions](https://github.com/pyjanitor-devs/pyjanitor/issues/1059)
111+
- [@OdinTech3](https://github.com/OdinTech3) | [contributions](https://github.com/pyjanitor-devs/pyjanitor/issues?q=is%3Aclosed+mentions%OdinTech3)
112+
- [@asmirnov69](https://github.com/asmirnov69) | [contributions](https://github.com/pyjanitor-devs/pyjanitor/issues?q=is%3Aclosed+mentions%asmirnov69)
113+
- [@xujiboy](https://github.com/xujiboy) | [contributions](https://github.com/pyjanitor-devs/pyjanitor/issues?q=is%3Aclosed+mentions%xujiboy)
114+
- [@joranbeasley](https://github.com/joranbeasley) | [contributions](https://github.com/pyjanitor-devs/pyjanitor/issues?q=is%3Aclosed+mentions%joranbeasley)

CHANGELOG.md

+1
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44

55
- [INF] Replace `pytest.ini` file with `pyproject.toml` file. PR #1204 @Zeroto521
66
- [INF] Extract docstrings tests from all tests. PR #1205 @Zeroto521
7+
- [BUG] address the `TypeError` when importing v0.24.0 (issue #1201 @xujiboy and @joranbeasley)
78

89
## [v0.24.0] - 2022-11-12
910

janitor/functions/conditional_join.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
1+
from __future__ import annotations
12
import operator
23
from enum import Enum
34
from typing import Union, Any, Optional, Hashable, Literal
4-
55
import numpy as np
66
import pandas as pd
77
import pandas_flavor as pf

janitor/functions/utils.py

+2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
"""Utility functions for all of the functions submodule."""
2+
3+
from __future__ import annotations
24
import fnmatch
35
import warnings
46
from collections.abc import Callable as dispatch_callable

janitor/utils.py

+3-2
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,11 @@
33
Lazy loading used here to speed up imports.
44
"""
55

6+
from __future__ import annotations
67
import os
78
import sys
89
import socket
9-
from typing import Callable, Dict, Iterable, Union
10+
from typing import Callable, Dict, Iterable, Union, List
1011
from functools import singledispatch, wraps
1112
from warnings import warn
1213

@@ -213,7 +214,7 @@ def idempotent(func: Callable, df: pd.DataFrame, *args, **kwargs):
213214

214215

215216
def deprecated_kwargs(
216-
*arguments: list[str],
217+
*arguments: List[str],
217218
message: str = (
218219
"The keyword argument '{argument}' of '{func_name}' is deprecated."
219220
),

0 commit comments

Comments
 (0)