Skip to content

Commit d0c2544

Browse files
samukwekusamuel.oranyeliericmjl
authored
[ENH] improve performance for polars' pivot_longer (#1377)
* faster pivot_longer for non dot value * fix docs and tests * fix docs and tests * fix doc * fix doc pivot_longer_spec * fix doc pivot_longer_spec * updates * updates * updates * fix docs * fix tests * change sort logic for `complete` * updates to complete * restore inital setup for complete * remove dead code * use left join * update docs for pivot_longer * WIP - expand * Delete janitor/polars/expand.py * remove expand * remove expand --------- Co-authored-by: samuel.oranyeli <[email protected]> Co-authored-by: Eric Ma <[email protected]>
1 parent 65ccf97 commit d0c2544

File tree

3 files changed

+279
-302
lines changed

3 files changed

+279
-302
lines changed

janitor/polars/complete.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -385,14 +385,14 @@ def _complete(
385385

386386
no_columns_to_fill = set(df.columns) == set(uniques.columns)
387387
if fill_value is None or no_columns_to_fill:
388-
return uniques.join(df, on=uniques.columns, how="full", coalesce=True)
388+
return uniques.join(df, on=uniques.columns, how="left", coalesce=True)
389389
idx = None
390390
columns_to_select = df.columns
391391
if not explicit:
392392
idx = "".join(df.columns)
393393
idx = f"{idx}_"
394394
df = df.with_row_index(name=idx)
395-
df = uniques.join(df, on=uniques.columns, how="full", coalesce=True)
395+
df = uniques.join(df, on=uniques.columns, how="left", coalesce=True)
396396
# exclude columns that were not used
397397
# to generate the combinations
398398
exclude_columns = uniques.columns

0 commit comments

Comments
 (0)