Skip to content

Commit 633c891

Browse files
samukwekusamuel.oranyeliericmjl
authored
[ENH] improve performance for polars' complete (#1389)
* remove ambiguity with structs * fix docs * pin numpy * fix docs * fix docs * add polars.expand * add polars.expand * add tests polars expand * pin setuptools * fix docs * fix docs * add extra test for polars expand * remove assumptions when fill_value is a dict * add test for pl.Series * fix column selection logic --------- Co-authored-by: samuel.oranyeli <[email protected]> Co-authored-by: Eric Ma <[email protected]>
1 parent a14061c commit 633c891

File tree

6 files changed

+421
-88
lines changed

6 files changed

+421
-88
lines changed

environment-dev.yml

+3-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ dependencies:
2525
- mypy
2626
- natsort
2727
- numba
28-
- numpy
28+
- numpy==1.24.4
2929
- openpyxl
3030
- pandas-flavor
3131
- pandas-vet
@@ -51,3 +51,5 @@ dependencies:
5151
- xorg-libxrender
5252
- pip:
5353
- mknotebooks
54+
# Temporarily pinned to fix CI
55+
- setuptools==70.3.0

janitor/functions/convert_date.py

-1
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,6 @@ def convert_matlab_date(
102102
return df.assign(**dictionary)
103103

104104

105-
@pf.register_dataframe_method
106105
@pf.register_dataframe_method
107106
@refactored_function(
108107
message=(

janitor/polars/__init__.py

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
from .clean_names import clean_names, make_clean_names
2-
from .complete import complete
2+
from .complete import complete, expand
33
from .dates_to_polars import convert_excel_date, convert_matlab_date
44
from .pivot_longer import pivot_longer, pivot_longer_spec
55
from .row_to_names import row_to_names
@@ -10,6 +10,7 @@
1010
"clean_names",
1111
"make_clean_names",
1212
"row_to_names",
13+
"expand",
1314
"complete",
1415
"convert_excel_date",
1516
"convert_matlab_date",

0 commit comments

Comments
 (0)