Disable -H when using _sudo=True

[DrSensor]

Hi, how to disable -H/--set-home flag when using _sudo=True?

a bit of context

# group_data/local.py

_sudo = True
_preserve_sudo_env = True

# deploy.py

from pyinfra.operations.server import shell, packages

packages(["direnv"]) # run as root

# I want to write the output to /home/$USER/... ; not /root/...
shell(["direnv hook fish > ~/.config/fish/conf.d/direnv.fish"])

after some inspection with pyinfra --debug inventory.py deploy.py

[pyinfra.connectors.local] --> Running command on localhost: env SUDO_ASKPASS=/tmp/pyinfra-sudo-askpass-vQ3t4mfcxJrY *** sudo -H -A -k -E sh -c 'direnv hook fish > ~/.config/fish/conf.d/direnv.fish'
[pyinfra.connectors.util] --> Waiting for exit status...
[pyinfra.connectors.util] --> Command exit status: 1

I notice it use -H

[DrSensor]

Just realized it's hardcoded here

pyinfra/pyinfra/connectors/util.py

Lines 345 to 347 in 2fb4fb0

	if _sudo:
	command_bits.extend(["sudo", "-H"])

I'm going to convert this to github issue and create PR to add _sudo_always_set_home¹ as global arguments to disable -H/--set-home flag (enable by default)

Footnotes

1. it's named _sudo_always_set_home because /etc/sudoers also has option for this called always_set_home ↩

[DrSensor]

my current solution

from os import getenv

_sudo = True
_env = {"HOME": f"/home/{getenv("USER")}"}

but dunno, this feel awkward.
I think _sudo_always_set_home=False + _preserve_sudo_env=True is better 🤔