Skip to content

Commit a430bd9

Browse files
committed
fix #1: broken test case due to a coding mistake
1 parent f0059a4 commit a430bd9

File tree

1 file changed

+9
-8
lines changed

1 file changed

+9
-8
lines changed

pyexcel_text/__init__.py

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -109,12 +109,13 @@ def close(self):
109109

110110

111111
class TextWriter(BookWriter):
112-
def __init__(self, file, **keywords):
113-
BookWriter.__init__(self, file, **keywords)
114-
if is_string(type(file)):
115-
self.f = open(file, 'w')
112+
def __init__(self, filename, **keywords):
113+
BookWriter.__init__(self, filename, **keywords)
114+
if is_string(type(filename)):
115+
self.f = open(filename, 'w')
116116
else:
117-
self.f = file
117+
self.f = filename
118+
self.filename = filename
118119

119120
def create_sheet(self, name):
120121
return TextSheetWriter(
@@ -124,7 +125,7 @@ def create_sheet(self, name):
124125
**self.keywords)
125126

126127
def close(self):
127-
if is_string(type(file)):
128+
if is_string(type(self.filename)):
128129
self.f.close()
129130

130131

@@ -142,8 +143,8 @@ def close(self):
142143

143144

144145
class JsonWriter(TextWriter):
145-
def __init__(self, file, **keywords):
146-
TextWriter.__init__(self, file, **keywords)
146+
def __init__(self, filename, **keywords):
147+
TextWriter.__init__(self, filename, **keywords)
147148

148149
def write(self, sheet_dicts):
149150
import json

0 commit comments

Comments
 (0)