Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTD's default version switcher became invisible #1161

Closed
kmaehashi opened this issue Feb 6, 2023 · 3 comments
Closed

RTD's default version switcher became invisible #1161

kmaehashi opened this issue Feb 6, 2023 · 3 comments

Comments

@kmaehashi
Copy link
Contributor

After bumping pydata-sphinx-theme from v0.9.0 to v0.12.0, I noticed that RTD's version switcher disappeared.

After setting a breakpoint, I noticed that the version switcher disappears at:

/*******************************************************************************
* MutationObserver to move the ReadTheDocs button
*/
/**
* intercept the RTD flyout and place it in the rtd-footer-container if existing
* if not it stays where on top of the page
*/
function initRTDObserver() {
const mutatedCallback = (mutationList, observer) => {
mutationList.forEach((mutation) => {
// Check whether the mutation is for RTD, which will have a specific structure
if (mutation.addedNodes.length === 0) {
return;
}
if (mutation.addedNodes[0].data === undefined) {
return;
}
if (mutation.addedNodes[0].data.search("Inserted RTD Footer") != -1) {
mutation.addedNodes.forEach((node) => {
document.getElementById("rtd-footer-container").append(node);
});
}
});
};
const observer = new MutationObserver(mutatedCallback);
const config = { childList: true };
observer.observe(document.body, config);
}

Is it possible to get the RTD's version switcher back on the docs?

@12rambau
Copy link
Collaborator

12rambau commented Feb 6, 2023

Duplicate of #1092

THe RDT flyout didn't really disappeared, it's is now part of the primary sidebar that is absent from many of your pages. I checked your documentation and it reappears there: https://docs.cupy.dev/en/v12.0.0b3/user_guide/index.html. We are trying to gracefully degrade this behavior for documentation without primary sidebars in #1133.

@kmaehashi
Copy link
Contributor Author

kmaehashi commented Feb 6, 2023

Sorry, I searched for issues but missed that one. Glad to know the improvement is ongoing!

kmaehashi added a commit to kmaehashi/cupy that referenced this issue Feb 6, 2023
@drammock
Copy link
Collaborator

drammock commented Feb 7, 2023

closing as duplicate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants