Skip to content

With json get mut #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

With json get mut #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
25114c5
[55_maintenance] Fix verify-release-candidate.sh by skipping `arrow-p…
alamb Jun 23, 2025
122f9aa
Add `get_ref/get_mut` to JSON Writer (#7854)
cetra3 Jul 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions arrow-json/src/writer/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,6 +413,19 @@ where
Ok(())
}

/// Gets a reference to the underlying writer.
pub fn get_ref(&self) -> &W {
&self.writer
}

/// Gets a mutable reference to the underlying writer.
///
/// Writing to the underlying writer must be done with care
/// to avoid corrupting the output JSON.
pub fn get_mut(&mut self) -> &mut W {
&mut self.writer
}

/// Unwraps this `Writer<W>`, returning the underlying writer
pub fn into_inner(self) -> W {
self.writer
Expand Down
6 changes: 5 additions & 1 deletion dev/release/verify-release-candidate.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,11 @@ test_source_distribution() {
export ARROW_TEST_DATA=$PWD/arrow-testing-data/data
export PARQUET_TEST_DATA=$PWD/parquet-testing-data/data

cargo test --all
# ignore arrow-pyarrow due to
# https://github.com/apache/arrow-rs/issues/7736
# ignore parquet-variant due to
# https://github.com/apache/arrow-rs/issues/7746
cargo test --all --exclude arrow-pyarrow --exclude parquet-variant

# verify that the leaf crates can be published to crates.io
# we can't verify crates that depend on others
Expand Down
Loading