Skip to content

Commit 5bf1716

Browse files
authored
Remove support for py38 and enable py312 testing (#1886)
1 parent 91798f4 commit 5bf1716

18 files changed

+224
-208
lines changed

.github/ISSUE_TEMPLATE/bug_report.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ body:
5050
attributes:
5151
label: Python Interpreter version
5252
description: The version(s) of Python used.
53-
placeholder: "3.8"
53+
placeholder: "3.9"
5454
validations:
5555
required: true
5656
- type: checkboxes

.github/workflows/jira_cloud_ci.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ jobs:
2323
os: [ubuntu-latest]
2424
# We only test a single version to prevent concurrent
2525
# running of tests influencing one another
26-
python-version: ["3.8"]
26+
python-version: ["3.9"]
2727

2828
steps:
2929
- uses: actions/checkout@v4
@@ -41,7 +41,7 @@ jobs:
4141
python -m pip install --upgrade tox tox-gh-actions
4242
4343
- name: Test with tox
44-
run: tox -e py38 -- -m allow_on_cloud
44+
run: tox -e py39 -- -m allow_on_cloud
4545
env:
4646
CI_JIRA_TYPE: CLOUD
4747
CI_JIRA_CLOUD_ADMIN: ${{ secrets.CLOUD_ADMIN }}

.github/workflows/jira_server_ci.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ jobs:
1111
strategy:
1212
matrix:
1313
os: [ubuntu-latest]
14-
python-version: ["3.8", "3.9", "3.10", "3.11"]
14+
python-version: ["3.9", "3.10", "3.11"]
1515
jira-version: [8.17.1]
1616

1717
steps:

.github/workflows/release.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,10 @@ jobs:
1717
TOX_PARALLEL_NO_SPINNER: 1
1818

1919
steps:
20-
- name: Switch to using Python 3.8 by default
20+
- name: Switch to using Python 3.9 by default
2121
uses: actions/setup-python@v5
2222
with:
23-
python-version: 3.8
23+
python-version: 3.9
2424

2525
- name: Install build dependencies
2626
run: python3 -m pip install --user tox

.github/workflows/tox.yml

+23-5
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,14 @@ jobs:
3232
lint
3333
docs
3434
pkg
35-
# ^ arm64 runner is using py311 for matching python version used in AAP 2.5
36-
platforms: linux,macos,linux-arm64:ubuntu-24.04-arm64-2core
35+
py39:tox -e py39 --notest
36+
py310:tox -e py310 --notest
37+
py311:tox -e py311 --notest
38+
py312:tox -e py312 --notest
39+
py39-macos:tox -e py312 --notest
40+
py312-macos:tox -e py312 --notest
41+
# ^ macos is also used to validate arm64 building
42+
platforms: linux,macos
3743
skip_explode: "1"
3844
build:
3945
name: ${{ matrix.name }}
@@ -45,6 +51,13 @@ jobs:
4551
matrix: ${{ fromJson(needs.prepare.outputs.matrix) }}
4652
steps:
4753

54+
- name: Install package dependencies (ubuntu)
55+
if: ${{ contains(matrix.os, 'ubuntu') }}
56+
run: |
57+
sudo apt remove -y docker-compose
58+
sudo apt-get update -y
59+
sudo apt-get --assume-yes --no-install-recommends install -y apt-transport-https curl libkrb5-dev
60+
4861
- uses: actions/checkout@v4
4962
with:
5063
fetch-depth: 0 # needed by setuptools-scm
@@ -138,8 +151,13 @@ jobs:
138151
name: logs.zip
139152
path: .
140153

141-
- name: Check for expected number of coverage reports
142-
run: .github/check-coverage.sh
154+
- name: Check for expected number of coverage.xml reports
155+
run: |
156+
JOBS_PRODUCING_COVERAGE=0
157+
if [ "$(find . -name coverage.xml | wc -l | bc)" -ne "${JOBS_PRODUCING_COVERAGE}" ]; then
158+
echo "::error::Number of coverage.xml files was not the expected one (${JOBS_PRODUCING_COVERAGE}): $(find . -name coverage.xml |xargs echo)"
159+
exit 1
160+
fi
143161
144162
# Single uploads inside check job for codecov to allow use to retry
145163
# it when it fails without running tests again. Fails often enough!
@@ -160,7 +178,7 @@ jobs:
160178
with:
161179
name: ${{ matrix.name }}
162180
# verbose: true # optional (default = false)
163-
fail_ci_if_error: true
181+
fail_ci_if_error: false
164182
use_oidc: true # cspell:ignore oidc
165183
files: "*/tests/output/reports/coverage.xml"
166184

bindep.txt

+2
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
# gssapi pypi wheel build needs:
2+
libkrb5-dev [platform:dpkg]

0 commit comments

Comments
 (0)