Skip to content

Commit 7f2214b

Browse files
henryiiihenryiii
authored
chore: bump cmake to 3.29 (#5075)
Signed-off-by: Henry Schreiner <[email protected]>
1 parent 7af193e commit 7f2214b

File tree

11 files changed

+29
-29
lines changed

11 files changed

+29
-29
lines changed

‎.github/workflows/configure.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ jobs:
3535

3636
- runs-on: ubuntu-20.04
3737
arch: x64
38-
cmake: "3.27"
38+
cmake: "3.29"
3939

4040
- runs-on: macos-latest
4141
arch: x64

‎CMakeLists.txt

+3-3
Original file line numberDiff line numberDiff line change
@@ -12,13 +12,13 @@ endif()
1212

1313
cmake_minimum_required(VERSION 3.5)
1414

15-
# The `cmake_minimum_required(VERSION 3.5...3.27)` syntax does not work with
15+
# The `cmake_minimum_required(VERSION 3.5...3.29)` syntax does not work with
1616
# some versions of VS that have a patched CMake 3.11. This forces us to emulate
1717
# the behavior using the following workaround:
18-
if(${CMAKE_VERSION} VERSION_LESS 3.27)
18+
if(${CMAKE_VERSION} VERSION_LESS 3.29)
1919
cmake_policy(VERSION ${CMAKE_MAJOR_VERSION}.${CMAKE_MINOR_VERSION})
2020
else()
21-
cmake_policy(VERSION 3.27)
21+
cmake_policy(VERSION 3.29)
2222
endif()
2323

2424
if(_pybind11_cmp0148)

‎docs/advanced/embedding.rst

+1-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ information, see :doc:`/compiling`.
1818

1919
.. code-block:: cmake
2020
21-
cmake_minimum_required(VERSION 3.5...3.27)
21+
cmake_minimum_required(VERSION 3.5...3.29)
2222
project(example)
2323
2424
find_package(pybind11 REQUIRED) # or `add_subdirectory(pybind11)`

‎docs/compiling.rst

+3-3
Original file line numberDiff line numberDiff line change
@@ -241,7 +241,7 @@ extension module can be created with just a few lines of code:
241241

242242
.. code-block:: cmake
243243
244-
cmake_minimum_required(VERSION 3.5...3.27)
244+
cmake_minimum_required(VERSION 3.5...3.29)
245245
project(example LANGUAGES CXX)
246246
247247
add_subdirectory(pybind11)
@@ -498,7 +498,7 @@ You can use these targets to build complex applications. For example, the
498498

499499
.. code-block:: cmake
500500
501-
cmake_minimum_required(VERSION 3.5...3.27)
501+
cmake_minimum_required(VERSION 3.5...3.29)
502502
project(example LANGUAGES CXX)
503503
504504
find_package(pybind11 REQUIRED) # or add_subdirectory(pybind11)
@@ -556,7 +556,7 @@ information about usage in C++, see :doc:`/advanced/embedding`.
556556

557557
.. code-block:: cmake
558558
559-
cmake_minimum_required(VERSION 3.5...3.27)
559+
cmake_minimum_required(VERSION 3.5...3.29)
560560
project(example LANGUAGES CXX)
561561
562562
find_package(pybind11 REQUIRED) # or add_subdirectory(pybind11)

‎tests/CMakeLists.txt

+3-3
Original file line numberDiff line numberDiff line change
@@ -7,13 +7,13 @@
77

88
cmake_minimum_required(VERSION 3.5)
99

10-
# The `cmake_minimum_required(VERSION 3.5...3.27)` syntax does not work with
10+
# The `cmake_minimum_required(VERSION 3.5...3.29)` syntax does not work with
1111
# some versions of VS that have a patched CMake 3.11. This forces us to emulate
1212
# the behavior using the following workaround:
13-
if(${CMAKE_VERSION} VERSION_LESS 3.27)
13+
if(${CMAKE_VERSION} VERSION_LESS 3.29)
1414
cmake_policy(VERSION ${CMAKE_MAJOR_VERSION}.${CMAKE_MINOR_VERSION})
1515
else()
16-
cmake_policy(VERSION 3.27)
16+
cmake_policy(VERSION 3.29)
1717
endif()
1818

1919
# Filter out items; print an optional message if any items filtered. This ignores extensions.

‎tests/test_cmake_build/installed_embed/CMakeLists.txt

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
cmake_minimum_required(VERSION 3.5)
22

3-
# The `cmake_minimum_required(VERSION 3.5...3.27)` syntax does not work with
3+
# The `cmake_minimum_required(VERSION 3.5...3.29)` syntax does not work with
44
# some versions of VS that have a patched CMake 3.11. This forces us to emulate
55
# the behavior using the following workaround:
6-
if(${CMAKE_VERSION} VERSION_LESS 3.27)
6+
if(${CMAKE_VERSION} VERSION_LESS 3.29)
77
cmake_policy(VERSION ${CMAKE_MAJOR_VERSION}.${CMAKE_MINOR_VERSION})
88
else()
9-
cmake_policy(VERSION 3.27)
9+
cmake_policy(VERSION 3.29)
1010
endif()
1111

1212
project(test_installed_embed CXX)

‎tests/test_cmake_build/installed_function/CMakeLists.txt

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
cmake_minimum_required(VERSION 3.5)
22
project(test_installed_module CXX)
33

4-
# The `cmake_minimum_required(VERSION 3.5...3.27)` syntax does not work with
4+
# The `cmake_minimum_required(VERSION 3.5...3.29)` syntax does not work with
55
# some versions of VS that have a patched CMake 3.11. This forces us to emulate
66
# the behavior using the following workaround:
7-
if(${CMAKE_VERSION} VERSION_LESS 3.27)
7+
if(${CMAKE_VERSION} VERSION_LESS 3.29)
88
cmake_policy(VERSION ${CMAKE_MAJOR_VERSION}.${CMAKE_MINOR_VERSION})
99
else()
10-
cmake_policy(VERSION 3.27)
10+
cmake_policy(VERSION 3.29)
1111
endif()
1212

1313
project(test_installed_function CXX)

‎tests/test_cmake_build/installed_target/CMakeLists.txt

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
cmake_minimum_required(VERSION 3.5)
22

3-
# The `cmake_minimum_required(VERSION 3.5...3.27)` syntax does not work with
3+
# The `cmake_minimum_required(VERSION 3.5...3.29)` syntax does not work with
44
# some versions of VS that have a patched CMake 3.11. This forces us to emulate
55
# the behavior using the following workaround:
6-
if(${CMAKE_VERSION} VERSION_LESS 3.27)
6+
if(${CMAKE_VERSION} VERSION_LESS 3.29)
77
cmake_policy(VERSION ${CMAKE_MAJOR_VERSION}.${CMAKE_MINOR_VERSION})
88
else()
9-
cmake_policy(VERSION 3.27)
9+
cmake_policy(VERSION 3.29)
1010
endif()
1111

1212
project(test_installed_target CXX)

‎tests/test_cmake_build/subdirectory_embed/CMakeLists.txt

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
cmake_minimum_required(VERSION 3.5)
22

3-
# The `cmake_minimum_required(VERSION 3.5...3.27)` syntax does not work with
3+
# The `cmake_minimum_required(VERSION 3.5...3.29)` syntax does not work with
44
# some versions of VS that have a patched CMake 3.11. This forces us to emulate
55
# the behavior using the following workaround:
6-
if(${CMAKE_VERSION} VERSION_LESS 3.27)
6+
if(${CMAKE_VERSION} VERSION_LESS 3.29)
77
cmake_policy(VERSION ${CMAKE_MAJOR_VERSION}.${CMAKE_MINOR_VERSION})
88
else()
9-
cmake_policy(VERSION 3.27)
9+
cmake_policy(VERSION 3.29)
1010
endif()
1111

1212
project(test_subdirectory_embed CXX)

‎tests/test_cmake_build/subdirectory_function/CMakeLists.txt

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
cmake_minimum_required(VERSION 3.5)
22

3-
# The `cmake_minimum_required(VERSION 3.5...3.27)` syntax does not work with
3+
# The `cmake_minimum_required(VERSION 3.5...3.29)` syntax does not work with
44
# some versions of VS that have a patched CMake 3.11. This forces us to emulate
55
# the behavior using the following workaround:
6-
if(${CMAKE_VERSION} VERSION_LESS 3.27)
6+
if(${CMAKE_VERSION} VERSION_LESS 3.29)
77
cmake_policy(VERSION ${CMAKE_MAJOR_VERSION}.${CMAKE_MINOR_VERSION})
88
else()
9-
cmake_policy(VERSION 3.27)
9+
cmake_policy(VERSION 3.29)
1010
endif()
1111

1212
project(test_subdirectory_function CXX)

‎tests/test_cmake_build/subdirectory_target/CMakeLists.txt

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
cmake_minimum_required(VERSION 3.5)
22

3-
# The `cmake_minimum_required(VERSION 3.5...3.27)` syntax does not work with
3+
# The `cmake_minimum_required(VERSION 3.5...3.29)` syntax does not work with
44
# some versions of VS that have a patched CMake 3.11. This forces us to emulate
55
# the behavior using the following workaround:
6-
if(${CMAKE_VERSION} VERSION_LESS 3.27)
6+
if(${CMAKE_VERSION} VERSION_LESS 3.29)
77
cmake_policy(VERSION ${CMAKE_MAJOR_VERSION}.${CMAKE_MINOR_VERSION})
88
else()
9-
cmake_policy(VERSION 3.27)
9+
cmake_policy(VERSION 3.29)
1010
endif()
1111

1212
project(test_subdirectory_target CXX)

0 commit comments

Comments
 (0)