Clean up double clicking

Author: gselzer

src/ndv/views/_jupyter/_app.py

@@ -92,13 +92,14 @@ def handle_event(self: RemoteFrameBuffer, ev: dict) -> None:
                 intercepted |= receiver.on_mouse_press(mpe)
                 receiver.mousePressed.emit(mpe)
             elif etype == "double_click":
-                # Step 1: Double Click
+                # Note that in Jupyter, a double_click event is not a pointer event
+                # and as such, we need to handle both press and release. See
+                # https://github.com/vispy/jupyter_rfb/blob/62831dd5a87bc19b4fd5f921d802ed21141e61ec/js/lib/widget.js#L270
                 btn = JupyterAppWrap.mouse_btn(ev["button"])
                 mpe = MousePressEvent(x=ev["x"], y=ev["y"], btn=btn)
                 intercepted |= receiver.on_mouse_double_press(mpe)
-                receiver.mousePressed.emit(mpe)
-                # Step 2: Release (Jupyter doesn't emit a release after double-click)
-                # TODO: What about double-click + move?
+                receiver.mouseDoublePressed.emit(mpe)
+                # Release
                 mre = MouseReleaseEvent(x=ev["x"], y=ev["y"], btn=btn)
                 intercepted |= receiver.on_mouse_release(mre)
                 receiver.mouseReleased.emit(mre)

src/ndv/views/_qt/_app.py

@@ -143,7 +143,7 @@ def eventFilter(self, obj: QObject | None, qevent: QEvent | None) -> bool:
                     self.active_button = btn
                     mpe = MousePressEvent(x=pos.x(), y=pos.y(), btn=self.active_button)
                     intercept |= receiver.on_mouse_double_press(mpe)
-                    receiver.mousePressed.emit(mpe)
+                    receiver.mouseDoublePressed.emit(mpe)
                 elif etype == QEvent.Type.MouseButtonPress:
                     self.active_button = btn
                     mpe = MousePressEvent(x=pos.x(), y=pos.y(), btn=self.active_button)

src/ndv/views/_wx/_app.py

@@ -102,6 +102,7 @@ def on_mouse_double_press(event: MouseEvent) -> None:
             active_button = MouseButton.LEFT
             mpe = MousePressEvent(x=event.GetX(), y=event.GetY(), btn=active_button)
             if not receiver.on_mouse_double_press(mpe):
+                receiver.mouseDoublePressed.emit(mpe)
                 event.Skip()
 
         def on_mouse_release(event: MouseEvent) -> None:

src/ndv/views/bases/_graphics/_mouseable.py

@@ -18,6 +18,7 @@ class Mouseable:
 
     mouseMoved = Signal(MouseMoveEvent)
     mousePressed = Signal(MousePressEvent)
+    mouseDoublePressed = Signal(MousePressEvent)
     mouseReleased = Signal(MouseReleaseEvent)
 
     def on_mouse_move(self, event: MouseMoveEvent) -> bool: