Skip to content

Consider removing the reuse_existing_virtualenvs parameter from noxfile.py #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
flpm opened this issue Oct 12, 2024 · 2 comments · Fixed by #420
Closed

Consider removing the reuse_existing_virtualenvs parameter from noxfile.py #419

flpm opened this issue Oct 12, 2024 · 2 comments · Fixed by #420

Comments

@flpm
Copy link
Member

flpm commented Oct 12, 2024

Currently nox is configured to reuse virtualenvs. This caused some issues with translations when some of the Sphinx modules were not updated.

Based on the informal discussion in Slack, multiple people voiced the preference to remove it (I lean towards that as well). We can use this issue to gather more feedback and make a decision.

nox.options.reuse_existing_virtualenvs = True

See issue #390 for how this parameter caused trouble while building the Spanish translation.

@willingc
Copy link
Collaborator

Seems reasonable to change. Do you wish to open a PR?

@flpm
Copy link
Member Author

flpm commented Oct 15, 2024

👍 I will make a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants