Skip to content

Commit ceef218

Browse files
committed
removed best.improvement from is_children_impurity_proxy condition
1 parent e1c1498 commit ceef218

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

econml/tree/_splitter.pyx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -630,8 +630,8 @@ cdef class BestSplitter(Splitter):
630630
best.impurity_left_val = best.impurity_left
631631
best.impurity_right_val = best.impurity_right
632632

633-
best.improvement = self.criterion.impurity_improvement(impurity,
634-
best.impurity_left, best.impurity_right)
633+
best.improvement = self.criterion.impurity_improvement(impurity,
634+
best.impurity_left, best.impurity_right)
635635

636636
# Respect invariant for constant features: the original order of
637637
# element in features[:n_known_constants] must be preserved for sibling

0 commit comments

Comments
 (0)