Skip to content

Commit 93441b7

Browse files
committed
arm64: cacheinfo: Avoid out-of-bounds write to cacheinfo array
jira VULN-54126 cve CVE-2025-21785 commit-author Radu Rendec <[email protected]> commit 875d742 The loop that detects/populates cache information already has a bounds check on the array size but does not account for cache levels with separate data/instructions cache. Fix this by incrementing the index for any populated leaf (instead of any populated level). Fixes: 5d425c1 ("arm64: kernel: add support for cpu cache information") Signed-off-by: Radu Rendec <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Will Deacon <[email protected]> (cherry picked from commit 875d742) Signed-off-by: Marcin Wcisło <[email protected]>
1 parent f10433c commit 93441b7

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

arch/arm64/kernel/cacheinfo.c

+7-5
Original file line numberDiff line numberDiff line change
@@ -98,16 +98,18 @@ static int __populate_cache_leaves(unsigned int cpu)
9898
unsigned int level, idx;
9999
enum cache_type type;
100100
struct cpu_cacheinfo *this_cpu_ci = get_cpu_cacheinfo(cpu);
101-
struct cacheinfo *this_leaf = this_cpu_ci->info_list;
101+
struct cacheinfo *infos = this_cpu_ci->info_list;
102102

103103
for (idx = 0, level = 1; level <= this_cpu_ci->num_levels &&
104-
idx < this_cpu_ci->num_leaves; idx++, level++) {
104+
idx < this_cpu_ci->num_leaves; level++) {
105105
type = get_cache_type(level);
106106
if (type == CACHE_TYPE_SEPARATE) {
107-
ci_leaf_init(this_leaf++, CACHE_TYPE_DATA, level);
108-
ci_leaf_init(this_leaf++, CACHE_TYPE_INST, level);
107+
if (idx + 1 >= this_cpu_ci->num_leaves)
108+
break;
109+
ci_leaf_init(&infos[idx++], CACHE_TYPE_DATA, level);
110+
ci_leaf_init(&infos[idx++], CACHE_TYPE_INST, level);
109111
} else {
110-
ci_leaf_init(this_leaf++, type, level);
112+
ci_leaf_init(&infos[idx++], type, level);
111113
}
112114
}
113115
return 0;

0 commit comments

Comments
 (0)