-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Description
Is your feature request related to a problem? Please describe.
Some details around axis_azimuth and axis_tilt in the docs (https://pvlib-python.readthedocs.io/en/stable/reference/generated/pvlib.tracking.singleaxis.html) seem ambiguous to me.
Examples:
- For a north-south aligned tracker axis, sloping 5 degrees down to the south, what are the inputs for axis_azimuth and axis_tilt? I assume axis_azimuth = 180, axis_tilt = 5.
- For the same north-south aligned tracker axis, but sloping 5 degrees down to the north, what are the inputs? I assume axis_azimuth = 0, axis_tilt = 5, since axis_tilt must be >= 0.
Additionally, the description in the docs includes:
For example, if tracker axis_azimuth is 180 (oriented south) and axis_tilt is zero...
But the default for axis_azimuth is 0, which could lead to confusion around inputs and output sign convention.
Describe the solution you'd like
More clear docs.
Additional context
Changing definitions slightly and allowing for negative axis_tilt would make more sense to me, but maybe that causes other problems. [edit: now I don't think this is a good idea - see the full discussion below] [2nd edit: looks like code allows for this even though docs do not. Also, my opinion is easily swayed...]
For example # 2 above (sloping down to the North), allowing for axis_azimuth = 180, axis_tilt = -5 makes more since to me. You could unambigously define axis_azimuth as "the South-most direction of the axis of rotation" and axis_tilt as "the tilt of the axis of rotation, with positive values indicating downward slope towards the South-most direction, and negative values indicating downward slope towards the North-most direction...".
I'm not sure how to handle the odd case of a tracker axis aligned perfectly East-West.
And for systems in the Southern Hemisphere, I don't think anything would need to change.