Skip to content

Puppeteer BrowserOptions overlaps with Lighthouse Config #231

@BioPhoton

Description

@BioPhoton

To handle different device sizes we have different places to configure them:

  • Lighthouse Config
  • Puppeteer Browser

Lighthouse Config

const lighthouseConfig: Config = {
  extends: 'lighthouse:default',
  settings: {
    formFactor: 'desktop',      
    screenEmulation: {
      mobile: false,
      width: 1350,
      height: 940,
      deviceScaleFactor: 1,
      disabled: false
    }
  }
}

This setting applies to the browsers window not the viewport.

Puppeteer BrowserOptions

// 
const browserOptions: BrowserOptions = {
  defaultViewport: { 
  isMobile: false, 
  isLandscape: false, 
   width: 1350,
   height: 940,
  }
}

This setting applies to the Browsers viewport, not window.

BrowserOptions-vs-LhConfig


This issue is slightly connected with #142

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions