Skip to content

Support PureScript's --exclude-files CLI arg #1064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JordanMartinez opened this issue Oct 9, 2023 · 4 comments
Closed

Support PureScript's --exclude-files CLI arg #1064

JordanMartinez opened this issue Oct 9, 2023 · 4 comments

Comments

@JordanMartinez
Copy link
Contributor

[email protected] allows one to exclude files from compiler input via the --exclude-files argument.

-x,--exclude-files ARG   Glob of .purs files to exclude from the supplied files.

How should this flag be supported given that we currently make the following assumptions:

  • a given package always contains its files in src/**/*.purs
  • a given package's test (if it exists) always exists in test/**/*.purs

AFAICT, the purpose of the --exclude-files is to allow one to have multiple packages within the same src directory.

@JordanMartinez JordanMartinez changed the title Support PureScript's --exclude-files CLI arg Support colocation - PureScript's --exclude-files CLI arg Oct 9, 2023
@JordanMartinez
Copy link
Contributor Author

Seems related to purescript/registry-dev#594

@f-f
Copy link
Member

f-f commented Oct 9, 2023

Why would we want to support this?

Spago has a specific idea of what a package is, and that does not play well with "splitting a src directory between multiple packages"

@f-f
Copy link
Member

f-f commented Oct 9, 2023

And I mentioned colocation in our chat earlier today - I think I got confused, doesn't seem related

@f-f f-f changed the title Support colocation - PureScript's --exclude-files CLI arg Support PureScript's --exclude-files CLI arg Oct 9, 2023
@f-f
Copy link
Member

f-f commented Oct 11, 2023

Me and Jordan had a call earlier today and agreed that we won't support this unless we have a good usecase

@f-f f-f closed this as completed Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants