fix: remove unnecessary check on output

Author: rwaffen

lib/facter/puppetdb_version.rb

@@ -3,11 +3,6 @@
 
   setcode do
     output = Facter::Core::Execution.execute('puppetdb --version')
-
-    if output.nil?
-      nil
-    else
-      output.split(':').last.strip
-    end
+    output.split(':').last.strip
   end
 end

spec/unit/facter/puppetdb_version_spec.rb

@@ -22,11 +22,4 @@
 
     expect(Facter.fact(:puppetdb_version).value).to be_nil
   end
-
-  it 'returns nil if puppetdb version output is nil' do
-    allow(Facter::Util::Resolution).to receive(:which).with('puppetdb').and_return('/usr/bin/puppetdb')
-    allow(Facter::Core::Execution).to receive(:execute).with('puppetdb --version').and_return(nil)
-
-    expect(Facter.fact(:puppetdb_version).value).to be_nil
-  end
 end