(CONT-792) - Correct RSpec/BeEq

puppetlabs · Apr 19, 2023 · 5bbd183 · 5bbd183
1 parent db6f562
commit 5bbd183
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 12 deletions.
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
@@ -44,11 +44,6 @@ Metrics/ParameterLists:
 Metrics/PerceivedComplexity:
   Max: 11
 
-# Offense count: 1
-# Naming/AccessorMethodName:
-#   Exclude:
-#     - 'lib/puppet/type/postgresql_psql.rb'
-
 # Offense count: 24
 # Configuration parameters: ForbiddenDelimiters.
 # ForbiddenDelimiters: (?i-mx:(^|\s)(EO[A-Z]{1}|END)(\s|$))
@@ -66,10 +61,10 @@ Naming/HeredocDelimiterNaming:
 
 # Offense count: 3
 # This cop supports unsafe autocorrection (--autocorrect-all).
-RSpec/BeEq:
-  Exclude:
-    - 'spec/functions/postgresql_postgresql_acls_to_resources_hash_spec.rb'
-    - 'spec/spec_helper_local.rb'
+# RSpec/BeEq:
+#   Exclude:
+#     - 'spec/functions/postgresql_postgresql_acls_to_resources_hash_spec.rb'
+#     - 'spec/spec_helper_local.rb'
 
 # Offense count: 2
 # This cop supports safe autocorrection (--autocorrect).

diff --git a/spec/functions/postgresql_postgresql_acls_to_resources_hash_spec.rb b/spec/functions/postgresql_postgresql_acls_to_resources_hash_spec.rb
@@ -3,7 +3,7 @@
 require 'spec_helper'
 
 describe 'postgresql::postgresql_acls_to_resources_hash' do
-  it { is_expected.not_to eq(nil) }
+  it { is_expected.not_to be_nil }
   context 'individual transform tests' do
     it do
       input = 'local   all             postgres                                ident'

diff --git a/spec/spec_helper_local.rb b/spec/spec_helper_local.rb
@@ -45,7 +45,7 @@ def param(type, title, param)
 end
 
 shared_examples 'postgresql_password function' do
-  it { is_expected.not_to eq(nil) }
+  it { is_expected.not_to be_nil }
 
   it {
     is_expected.to run.with_params('foo', 'bar').and_return(
@@ -73,7 +73,7 @@ def param(type, title, param)
 end
 
 shared_examples 'postgresql_escape function' do
-  it { is_expected.not_to eq(nil) }
+  it { is_expected.not_to be_nil }
   it {
     is_expected.to run.with_params('foo')
                       .and_return('$$foo$$')