Skip to content

Commit 8c5ba7b

Browse files
authored
Merge pull request #1527 from puppetlabs/pdksync_CONT-494/pin_github_changelog_generator
pdksync - (CONT-494) Pin github_changelog_generator and JSON gem versions
2 parents 6ab0d29 + b1d5f0c commit 8c5ba7b

File tree

5 files changed

+25
-19
lines changed

5 files changed

+25
-19
lines changed

.github/workflows/nightly.yml

+6-6
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ jobs:
1818
matrix: ${{ steps.get-matrix.outputs.matrix }}
1919

2020
steps:
21-
21+
2222
- name: "Honeycomb: Start recording"
2323
uses: puppetlabs/kvrhdn-gha-buildevents@pdk-templates-v1
2424
with:
@@ -54,9 +54,9 @@ jobs:
5454
buildevents step $TRACE_ID $STEP_ID $STEP_START 'Setup Environment'
5555
echo STEP_ID=Setup-Acceptance-Test-Matrix >> $GITHUB_ENV
5656
echo STEP_START=$(date +%s) >> $GITHUB_ENV
57-
5857
- name: Setup Acceptance Test Matrix
5958
id: get-matrix
59+
if: ${{ github.repository_owner == 'puppetlabs' }}
6060
run: |
6161
if [ '${{ github.repository_owner }}' == 'puppetlabs' ]; then
6262
buildevents cmd $TRACE_ID $STEP_ID matrix_from_metadata -- bundle exec matrix_from_metadata_v2
@@ -123,10 +123,10 @@ jobs:
123123
echo STEP_ID=${{ matrix.platforms.image }}-${{ matrix.collection }}-2 >> $GITHUB_ENV
124124
echo STEP_START=$(date +%s) >> $GITHUB_ENV
125125
126-
- name: "Disable mysqld apparmor profile"
127-
if: matrix.platforms.provider == 'provision::docker'
128-
run: |
129-
sudo ln -s /etc/apparmor.d/usr.sbin.mysqld /etc/apparmor.d/disable/
126+
- name: "Disable mysqld apparmor profile"
127+
if: matrix.platforms.provider == 'provision::docker'
128+
run: |
129+
sudo ln -s /etc/apparmor.d/usr.sbin.mysqld /etc/apparmor.d/disable/
130130
sudo apparmor_parser -R /etc/apparmor.d/disable/usr.sbin.mysqld
131131
132132
- name: Provision test environment

.github/workflows/pr_test.yml

+10-9
Original file line numberDiff line numberDiff line change
@@ -45,13 +45,14 @@ jobs:
4545
echo ::group::bundler environment
4646
buildevents cmd $TRACE_ID $STEP_ID 'bundle env' -- bundle env
4747
echo ::endgroup::
48-
48+
4949
- name: "Honeycomb: Record Setup Environment time"
5050
if: ${{ github.repository_owner == 'puppetlabs' }}
5151
run: |
5252
buildevents step $TRACE_ID $STEP_ID $STEP_START 'Setup Environment'
5353
echo STEP_ID=Setup-Acceptance-Test-Matrix >> $GITHUB_ENV
5454
echo STEP_START=$(date +%s) >> $GITHUB_ENV
55+
5556
- name: Run validation steps
5657
run: |
5758
bundle exec rake validate
@@ -90,7 +91,7 @@ jobs:
9091
echo 'platform=${{ matrix.platforms.image }}' >> $BUILDEVENT_FILE
9192
echo 'collection=${{ matrix.collection }}' >> $BUILDEVENT_FILE
9293
echo 'label=${{ matrix.platforms.label }}' >> $BUILDEVENT_FILE
93-
94+
9495
- name: "Honeycomb: Start recording"
9596
uses: puppetlabs/kvrhdn-gha-buildevents@pdk-templates-v1
9697
with:
@@ -117,18 +118,18 @@ jobs:
117118
echo ::group::bundler environment
118119
buildevents cmd $TRACE_ID $STEP_ID 'bundle env' -- bundle env
119120
echo ::endgroup::
120-
121+
121122
- name: "Honeycomb: Record Setup Environment time"
122123
if: ${{ always() }}
123124
run: |
124125
buildevents step $TRACE_ID $STEP_ID $STEP_START 'Setup Environment'
125126
echo STEP_ID=${{ matrix.platforms.image }}-${{ matrix.collection }}-2 >> $GITHUB_ENV
126127
echo STEP_START=$(date +%s) >> $GITHUB_ENV
127128
128-
- name: "Disable mysqld apparmor profile"
129-
if: matrix.platforms.provider == 'provision::docker'
130-
run: |
131-
sudo ln -s /etc/apparmor.d/usr.sbin.mysqld /etc/apparmor.d/disable/
129+
- name: "Disable mysqld apparmor profile"
130+
if: matrix.platforms.provider == 'provision::docker'
131+
run: |
132+
sudo ln -s /etc/apparmor.d/usr.sbin.mysqld /etc/apparmor.d/disable/
132133
sudo apparmor_parser -R /etc/apparmor.d/disable/usr.sbin.mysqld
133134
134135
- name: Provision test environment
@@ -168,7 +169,7 @@ jobs:
168169
- name: Run acceptance tests
169170
run: |
170171
buildevents cmd $TRACE_ID $STEP_ID 'rake litmus:acceptance:parallel' -- bundle exec rake 'litmus:acceptance:parallel'
171-
172+
172173
- name: "Honeycomb: Record acceptance testing times"
173174
if: ${{ always() }}
174175
run: |
@@ -186,7 +187,7 @@ jobs:
186187
echo
187188
echo ::endgroup::
188189
fi
189-
190+
190191
- name: "Honeycomb: Record removal times"
191192
if: ${{ always() }}
192193
run: |

.sync.yml

+1
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ Gemfile:
88
optional:
99
":development":
1010
- gem: github_changelog_generator
11+
version: '= 1.15.2'
1112
spec/spec_helper.rb:
1213
spec_overrides:
1314
- require 'spec_helper_local'

Gemfile

+7-3
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,12 @@ def location_for(place_or_version, fake_version = nil)
1414
end
1515

1616
group :development do
17-
gem "json", '~> 2.0', require: false
18-
gem "voxpupuli-puppet-lint-plugins", '~> 3.0', require: false
17+
gem "json", '= 2.1.0', require: false if Gem::Requirement.create(['>= 2.5.0', '< 2.7.0']).satisfied_by?(Gem::Version.new(RUBY_VERSION.dup))
18+
gem "json", '= 2.3.0', require: false if Gem::Requirement.create(['>= 2.7.0', '< 3.0.0']).satisfied_by?(Gem::Version.new(RUBY_VERSION.dup))
19+
gem "json", '= 2.5.1', require: false if Gem::Requirement.create(['>= 3.0.0', '< 3.0.5']).satisfied_by?(Gem::Version.new(RUBY_VERSION.dup))
20+
gem "json", '= 2.6.1', require: false if Gem::Requirement.create(['>= 3.1.0', '< 3.1.3']).satisfied_by?(Gem::Version.new(RUBY_VERSION.dup))
21+
gem "json", '= 2.6.3', require: false if Gem::Requirement.create(['>= 3.2.0', '< 4.0.0']).satisfied_by?(Gem::Version.new(RUBY_VERSION.dup))
22+
gem "voxpupuli-puppet-lint-plugins", '~> 3.1', require: false
1923
gem "facterdb", '~> 1.18', require: false
2024
gem "metadata-json-lint", '>= 2.0.2', '< 4.0.0', require: false
2125
gem "puppetlabs_spec_helper", '>= 3.0.0', '< 5.0.0', require: false
@@ -30,7 +34,7 @@ group :development do
3034
gem "rubocop-performance", '= 1.9.1', require: false
3135
gem "rubocop-rspec", '= 2.0.1', require: false
3236
gem "rb-readline", '= 0.5.5', require: false, platforms: [:mswin, :mingw, :x64_mingw]
33-
gem "github_changelog_generator", require: false
37+
gem "github_changelog_generator", '= 1.15.2', require: false
3438
end
3539
group :system_tests do
3640
gem "puppet_litmus", '< 1.0.0', require: false, platforms: [:ruby]

metadata.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,6 @@
8484
],
8585
"description": "MySQL module",
8686
"template-url": "https://github.com/puppetlabs/pdk-templates#main",
87-
"template-ref": "tags/2.6.0-0-gd0490b9",
87+
"template-ref": "2.7.1-0-g9a16c87",
8888
"pdk-version": "2.5.0"
8989
}

0 commit comments

Comments
 (0)