Trying to implement ability to set lifecycle_configuration.

Author: Antiarchitect

lib/puppet/provider/s3_bucket/v2.rb

@@ -24,6 +24,13 @@ def self.instances
         Puppet.debug("An error occurred reading the policy on S3 bucket #{s3_bucket.name}: " + e.message)
       end
 
+      begin
+        results = s3_client.get_bucket_lifecycle_configuration({bucket: s3_bucket.name})
+        data[:lifecycle_configuration] = { lifecycle_configuration: results.to_h }
+      rescue Exception => e
+        Puppet.debug("An error occurred reading the lifecycle configuration on S3 bucket #{s3_bucket.name}: " + e.message)
+      end
+
       new(data)
     end
     bucket_list.reject {|b| b.nil? }
@@ -61,4 +68,12 @@ def policy=(value)
     })
   end
 
+  def lifecycle_configuration=(value)
+    Puppet.debug('Replacing bucket lifecycle configuration')
+    s3_client.put_bucket_lifecycle_configuration({
+      bucket: @property_hash[:name],
+      lifecycle_configuration: value[:lifecycle_configuration]
+    })
+  end
+
 end

lib/puppet/type/s3_bucket.rb

@@ -17,18 +17,36 @@
   newproperty(:policy) do
     desc 'The policy document JSON string to apply'
     validate do |value|
-      fail Puppet::Error, 'Policy documents must be JSON strings' unless value.is_a? String
+      fail Puppet::Error, 'Policy documents must be JSON strings' unless is_valid_json?(value)
     end
 
     munge do |value|
-      begin
-        data = JSON.parse(value)
-        JSON.pretty_generate(data)
-      rescue
-        fail('Policy string is not valid JSON')
-      end
+      JSON.pretty_generate(JSON.parse(value))
+    rescue
+      fail('Policy string is not valid JSON')
     end
   end
 
+  newproperty(:lifecycle_configuration) do
+    desc 'The lifecycle configuration document JSON string to apply'
+    validate do |value|
+      fail Puppet::Error, 'Lifecycle configuration documents must be JSON strings' unless is_valid_json?(value)
+    end
+
+    munge do |value|
+      JSON.pretty_generate(JSON.parse(value))
+    rescue
+      fail('Lifecycle configuration string is not valid JSON')
+    end
+  end
+
+  private
+
+    def is_valid_json?(string)
+      !!JSON.parse(string)
+    rescue JSON::ParserError => _e
+      false
+    end
+
 end