Skip to content

Commit 1eaa5f4

Browse files
committed
Adding try catch for parent process kill and increasing time interval for killed process check.
1 parent d0c784d commit 1eaa5f4

File tree

1 file changed

+10
-6
lines changed

1 file changed

+10
-6
lines changed

lib/Local.js

+10-6
Original file line numberDiff line numberDiff line change
@@ -259,13 +259,17 @@ function Local(){
259259
var killChecker = setInterval(() => {
260260
if(childPids.length === 0) {
261261
clearInterval(killChecker);
262-
process.kill(this.pid);
263-
264-
// This gives time to local binary to send kill signal to railsApp.
265-
setTimeout(() => {
262+
try {
263+
process.kill(this.pid);
264+
// This gives time to local binary to send kill signal to railsApp.
265+
setTimeout(() => {
266+
this.isProcessRunning = false;
267+
callback();
268+
}, 2000);
269+
} catch(err) {
266270
this.isProcessRunning = false;
267271
callback();
268-
}, 2000);
272+
}
269273
}
270274
for(var i in childPids) {
271275
try {
@@ -274,7 +278,7 @@ function Local(){
274278
childPids.splice(i, 1);
275279
}
276280
}
277-
},100);
281+
},500);
278282
});
279283
};
280284
}

0 commit comments

Comments
 (0)