Windows Changes

Author: vedharish

.eslintrc.json

@@ -8,10 +8,6 @@
       2,
       "single"
     ],
-    "linebreak-style": [
-      2,
-      "unix"
-    ],
     "semi": [
       2,
       "always"

lib/Local.js

@@ -12,7 +12,7 @@ function Local(){
   this.logfile = path.join(process.cwd(), 'local.log');
   this.exitCallback;
 
-  this.errorRegex = /\*\*\* Error: [^\n]+/i;
+  this.errorRegex = /\*\*\* Error: [^\r\n]*/i;
   this.doneRegex = /Press Ctrl-C to exit/i;
 
   this.start = function(options, callback){
@@ -46,7 +46,6 @@ function Local(){
         bytesRead += bytes;
 
         var data = buffRead.toString();
-        //console.log(data);
 
         if(data.match(that.errorRegex)){
           fs.closeSync(that.stdout);

lib/LocalBinary.js

@@ -10,9 +10,9 @@ function LocalBinary(){
 
   if(this.hostOS.match(/darwin|mac os/i)){
     this.httpPath = 'https://s3.amazonaws.com/browserStack/browserstack-local/BrowserStackLocal-darwin-x64';
-  } else if(this.hostOS.match(/mswin|msys|mingw|cygwin|bccwin|wince|emc/i)) {
+  } else if(this.hostOS.match(/mswin|msys|mingw|cygwin|bccwin|wince|emc|win32/i)) {
     this.windows = true;
-    this.httpPath = 'https://s3.amazonaws.com/browserStack/browserstack-local/BrowserStackLocal-win32.exe';
+    this.httpPath = 'https://s3.amazonaws.com/browserStack/browserstack-local/BrowserStackLocal.exe';
   } else {
     if(this.is64bits)
       this.httpPath = 'https://s3.amazonaws.com/browserStack/browserstack-local/BrowserStackLocal-linux-x64';
@@ -24,7 +24,8 @@ function LocalBinary(){
     if(!this.checkPath(destParentDir))
       fs.mkdirSync(destParentDir);
 
-    var binaryPath = path.join(destParentDir, 'BrowserStackLocal');
+    var destBinaryName = (this.windows) ? 'BrowserStackLocal.exe' : 'BrowserStackLocal';
+    var binaryPath = path.join(destParentDir, destBinaryName);
     var file = fs.createWriteStream(binaryPath);
 
     https.get(this.httpPath, function (response) {
@@ -39,7 +40,8 @@ function LocalBinary(){
 
   this.binaryPath = function(callback){
     var destParentDir = this.getAvailableDirs();
-    var binaryPath = path.join(destParentDir, 'BrowserStackLocal');
+    var destBinaryName = (this.windows) ? 'BrowserStackLocal.exe' : 'BrowserStackLocal';
+    var binaryPath = path.join(destParentDir, destBinaryName);
     if(this.checkPath(binaryPath, fs.X_OK)){
       callback(binaryPath);
     } else {

package.json

@@ -5,7 +5,7 @@
   "main": "index.js",
   "scripts": {
     "pretest": "./node_modules/.bin/eslint lib/* index.js",
-    "test": "NODE_ENV=testing ./node_modules/.bin/mocha"
+    "test": "./node_modules/.bin/mocha"
   },
   "keywords": [
     "BrowserStack",

test/local.js

@@ -30,7 +30,7 @@ describe('Local', function () {
     bsLocal.start({ key: process.env.BROWSERSTACK_ACCESS_KEY }, function(){
       bsLocal_2 = new browserstack.Local();
       try{
-        bsLocal_2.start({ key: process.env.BROWSERSTACK_ACCESS_KEY }, function(){});  
+        bsLocal_2.start({ key: process.env.BROWSERSTACK_ACCESS_KEY, logfile: "C:\\Users\\Admin\\Desktop\\local.log" }, function(){});
       }
       catch(err){
         expect(err.toString().trim()).to.equal('LocalError: *** Error: Either another browserstack local client is running on your machine or some server is listening on port 45691');