Replaced outdated jshint for ESlint. Refactored all non compliant main pumascript files.

Author: Undre4m

.eslintignore

@@ -0,0 +1,4 @@
+**/node_modules/
+**/bower_components/
+**/thirdparty/
+**/dist/

.eslintrc.js

@@ -0,0 +1,45 @@
+module.exports = {
+    "env": {
+        "browser": true,
+        "node": true,
+        "es6": true,
+        "amd": true,
+        "phantomjs": true,
+        "qunit": true,
+        "jquery": true
+    },
+    "extends": "eslint:recommended",
+    "parserOptions": {
+        "sourceType": "module"
+    },
+    "globals": {},
+    "rules": {
+        "no-console": 0,
+        "block-scoped-var": 2,
+        "eqeqeq": 2,
+        "no-alert": 2,
+        "no-empty-function": [2, { "allow": ["arrowFunctions", "constructors"] }],
+        "no-eval": 2,
+        "no-multi-spaces": [2, {
+            "ignoreEOLComments": true,
+            "exceptions": { "VariableDeclarator": true, "Property": true }
+        }],
+        "no-multi-str": 2,
+        "no-new": 2,
+        "prefer-promise-reject-errors": [2, { "allowEmptyReject": true }],
+        "no-unused-vars": [1, { "args": "none" }],
+        "no-use-before-define": [2, { "functions": false, "classes": false }],
+        "global-require": 1,
+        "no-path-concat": 2,
+        "comma-dangle": [2, "never"],
+        "comma-style": [2, "last"],
+        "indent": [2, 4, { "SwitchCase": 1 }],
+        "keyword-spacing": [1, { "before": true, "after": true }],
+        "linebreak-style": [process.env.NODE_ENV === 'testing' ? 2 : 0, "unix"],
+        "no-trailing-spaces": [2, { "ignoreComments": false }],
+        "no-whitespace-before-property": 2,
+        "quotes": [2, "single"],
+        "semi": [2, "always"],
+        "semi-style": [2, "last"]
+    }
+};

.gitignore

@@ -3,7 +3,7 @@
 **/bower_components/
 
 # configuration and auto-generated files
-npm-debug.log
+**/*.log
 .idea
 .DS_Store
 

.npmignore

@@ -8,7 +8,8 @@ tracks/
 editor/
 
 # Configuration files for development
-.jshintrc
+.eslintrc.js
+.eslintignore
 .travis.yml
 
 # Tasks

.npmrc

@@ -0,0 +1 @@
+package-lock=false

editor/editor.js

@@ -36,18 +36,18 @@ require([
 ], function ($, CodeMirror, puma) {
 
     function PumaEditor() {
-        this._javaScriptEditor = this.instantiateCodeMirrorEditor("javascript");
-        this._pumaScriptEditor = this.instantiateCodeMirrorEditor("puma");
+        this._javaScriptEditor = this.instantiateCodeMirrorEditor('javascript');
+        this._pumaScriptEditor = this.instantiateCodeMirrorEditor('puma');
         this.registerEvents();
     }
 
     PumaEditor.prototype.instantiateCodeMirrorEditor = function (section) {
         return CodeMirror(document.getElementById(section), {
-            mode: "javascript",
+            mode: 'javascript',
             extraKeys: {
-                "Ctrl-Space": "autocomplete",
-                "Ctrl-J": "autocomplete",
-                "Ctrl-Q": function (cm) {
+                'Ctrl-Space': 'autocomplete',
+                'Ctrl-J': 'autocomplete',
+                'Ctrl-Q': function (cm) {
                     cm.foldCode(cm.getCursor());
                 }
             },
@@ -56,7 +56,7 @@ require([
             indentUnit: 4,
             tabSize: 4,
             foldGutter: true,
-            gutters: ["CodeMirror-linenumbers", "CodeMirror-foldgutter"]
+            gutters: ['CodeMirror-linenumbers', 'CodeMirror-foldgutter']
         });
     };
 
@@ -69,11 +69,11 @@ require([
     };
 
     PumaEditor.prototype.load = function () {
-        this.setEditorValue(this._pumaScriptEditor, localStorage.getItem("puma"));
+        this.setEditorValue(this._pumaScriptEditor, localStorage.getItem('puma'));
     };
 
     PumaEditor.prototype.loadBackup = function () {
-        this.setEditorValue(this._pumaScriptEditor, localStorage.getItem("puma-backup"));
+        this.setEditorValue(this._pumaScriptEditor, localStorage.getItem('puma-backup'));
     };
 
     PumaEditor.prototype.translate = function () {
@@ -82,8 +82,8 @@ require([
 
         //Save the last execution in local storage
         if (programStr !== '') {
-            localStorage.setItem("puma-backup", localStorage.getItem("puma"));
-            localStorage.setItem("puma", programStr);
+            localStorage.setItem('puma-backup', localStorage.getItem('puma'));
+            localStorage.setItem('puma', programStr);
         }
 
         if (programStr !== undefined && programStr !== null) {
@@ -98,11 +98,11 @@ require([
     };
 
     PumaEditor.prototype.registerEvents = function () {
-        $("#translatePuma").click(this.translate.bind(this));
+        $('#translatePuma').click(this.translate.bind(this));
 
-        $("#loadPuma").click(this.load.bind(this));
+        $('#loadPuma').click(this.load.bind(this));
 
-        $("#loadBackupPuma").click(this.loadBackup.bind(this));
+        $('#loadBackupPuma').click(this.loadBackup.bind(this));
     };
 
     var pumaEditorInstance = new PumaEditor();

gruntfile.js

@@ -1,5 +1,7 @@
 // Copyright (c) 2013 - present UTN-LIS
 
+/* eslint global-require: 0 */
+
 module.exports = function (grunt) {
 
     'use strict';
@@ -13,17 +15,18 @@ module.exports = function (grunt) {
             output: 'dist/<%= buildConfig.name %>'
         },
 
-        jshint: {
-            all: [
-                'gruntfile.js',
-                'src/**/*.js',
-                'tasks/*.js',
-                'test/*.js'
-            ],
+        eslint: {
             options: {
-                jshintrc: '.jshintrc',
-                reporter: require('jshint-stylish')
-            }
+                configFile: '.eslintrc.js',
+                format: 'stylish'
+            },
+            target: [
+                './editor/*.js',
+                './src/**/*.js',
+                './test/suites/*.js',
+                './test/*.js',
+                './tracks/**/*.js'
+            ]
         },
 
         exec: {
@@ -37,7 +40,7 @@ module.exports = function (grunt) {
                 options: {
                     sourceMap: true,
                     sourceMapName: 'dist/pumascript.min.map',
-                    sourceMapIn: 'dist/pumascript.map',
+                    sourceMapIn: 'dist/pumascript.map'
                 },
                 files: {
                     'dist/pumascript.min.js': [ 'dist/pumascript.js' ]
@@ -90,7 +93,7 @@ module.exports = function (grunt) {
     // plugin's task(s), then test the result.
     grunt.registerTask('test', ['clean', 'exec:webpack', 'qunit']);
 
-    grunt.registerTask('travis', ['jshint', 'test']);
+    grunt.registerTask('travis', ['eslint', 'test']);
 
     grunt.registerTask('default', ['init']);
 };

package.json

@@ -35,13 +35,13 @@
         "escodegen": "1.6.1"
     },
     "devDependencies": {
+        "eslint": "^4.8.0",
         "grunt": "0.4.5",
         "grunt-contrib-clean": "0.7.0",
-        "grunt-contrib-jshint": "0.11.3",
         "grunt-contrib-qunit": "0.5.1",
         "grunt-contrib-uglify": "2.1.0",
+        "grunt-eslint": "^20.1.0",
         "grunt-exec": "1.0.1",
-        "jshint-stylish": "1.0.1",
         "load-grunt-tasks": "3.1.0",
         "webpack": "2.2.1"
     },

src/prune-pass.js

@@ -13,7 +13,7 @@ define([], function () {
     }
 
     PrunePass.prototype.start = function () {
-        if (this._programAst === null) throw "null ast";
+        if (this._programAst === null) throw 'null ast';
         var tree = this._programAst.body;
         var prunedAst = this.walk(tree);
         return prunedAst;