internal: use (URN, ID) pairs in self-references

[t0yv0]

In #164 we improved the code for attaching provider Resource Option for self-referencing RegisterResource calls emanating from the pulumi-terraform-module provider. These currently use self-URN captured in CheckConfig/Configure. But in reality in full generality of Pulumi, provider self-references are (URN, ID) pairs.

This is a reminder to fix the code to include self-ID in these.

Possibly like this:

type wrap struct {
   pulumi.ProviderResourceState
   id pulumi.ID
}

func (*wrap) ID() pulumi.IDOutput{
   return toOutput(pulumi.ID)
}

[Frassle]

These currently use self-URN captured in CheckConfig/Configure. But in reality in full generality of Pulumi, provider self-references are (URN, ID) pairs.

They're actually ignored unless they are "URN::ID". I think that ignoring is an engine bug and it should have actually been erroring that the provider reference was malformed.

[t0yv0]

To be honest I'm not sure how to interpret that comment, because we are currently sending URN-only self references and that fixes significant issues for us. Perhaps there is a lot of detail here that is hard to summarize.

[Frassle]

So I tracked it down to your grabbing the URN and then using RegisterResource to read the URN to get the ID then sending that as the provider field, so it all works out.

[Frassle]

You'll get the wrong providers in cases of provider replacements though, so should look at fixing this with something like pulumi/pulumi-dotnet#533

[t0yv0]

What is an example of a provider replacement?