Skip to content

Commit e64a0c7

Browse files
tgummerertgummerer
authored
always run all integration tests (#360)
Currently the CI workflow in this repo runs each integration test individually. This makes it very easy to forget to add a test to the list, that's then never run in CI, even though it should be. Fix this by introducing a new Makefile target, to run all integration tests, and running that in CI instead of spelling each test out individually, which is very brittle.
1 parent c748bb9 commit e64a0c7

File tree

2 files changed

+21
-75
lines changed

2 files changed

+21
-75
lines changed

‎.github/workflows/pr.yml

+18-75
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,14 @@ jobs:
8686
go-version: 1.22.x
8787
- name: Install Pulumi CLI
8888
uses: pulumi/actions@v5
89+
- name: Install gotestsum
90+
uses: jaxxstorm/[email protected]
91+
env:
92+
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
93+
with:
94+
repo: gotestyourself/gotestsum
95+
tag: v1.8.1
96+
cache: enable
8997
- name: Install netcoredbg (Linux)
9098
if: matrix.os == 'ubuntu-latest'
9199
run: |
@@ -101,84 +109,19 @@ jobs:
101109
if: matrix.os == 'windows-latest'
102110
run: |
103111
scoop install netcoredbg
104-
- name: Install netcoredbg (Linux)
105-
if: matrix.os == 'ubuntu-latest'
112+
- name: Install netcoredbg (MacOS)
113+
if: matrix.os == 'macos-12'
114+
id: netcoredbg
106115
run: |
107116
curl -sSL https://github.com/Samsung/netcoredbg/releases/download/3.1.1-1042/netcoredbg-osx-amd64.tar.gz -o netcoredbg.tar.gz
108117
tar xzf netcoredbg.tar.gz
109-
sudo cp netcoredbg/* /usr/bin/
110-
- name: TestEmptyDotNet
111-
run: dotnet run integration test TestEmptyDotNet
112-
- name: TestStackReferenceDotnet
113-
run: dotnet run integration test TestStackReferenceDotnet
114-
- name: TestConstructDotnet
115-
run: dotnet run integration test TestConstructDotnet
116-
- name: TestPrintfDotNet
117-
run: dotnet run integration test TestPrintfDotNet
118-
- name: TestStackOutputsDotNet
119-
run: dotnet run integration test TestStackOutputsDotNet
120-
- name: TestStackComponentDotNet
121-
run: dotnet run integration test TestStackComponentDotNet
122-
- name: TestStackComponentServiceProviderDotNet
123-
run: dotnet run integration test TestStackComponentServiceProviderDotNet
124-
- name: TestConfigBasicDotNet
125-
run: dotnet run integration test TestConfigBasicDotNet
126-
- name: TestConfigSecretsWarnDotNet
127-
run: dotnet run integration test TestConfigSecretsWarnDotNet
128-
- name: TestStackReferenceSecretsDotnet
129-
run: dotnet run integration test TestStackReferenceSecretsDotnet
130-
- name: TestLargeResourceDotNet
131-
run: dotnet run integration test TestLargeResourceDotNet
132-
- name: TestConstructPlainDotnet
133-
run: dotnet run integration test TestConstructPlainDotnet
134-
- name: TestConstructUnknownDotnet
135-
run: dotnet run integration test TestConstructUnknownDotnet
136-
- name: TestConstructMethodsDotnet
137-
run: dotnet run integration test TestConstructMethodsDotnet
138-
- name: TestConstructMethodsUnknownDotnet
139-
run: dotnet run integration test TestConstructMethodsUnknownDotnet
140-
- name: TestConstructMethodsErrorsDotnet
141-
run: dotnet run integration test TestConstructMethodsErrorsDotnet
142-
- name: TestConstructProviderDotnet
143-
run: dotnet run integration test TestConstructProviderDotnet
144-
- name: TestGetResourceDotnet
145-
run: dotnet run integration test TestGetResourceDotnet
146-
- name: TestAboutDotnet
147-
run: dotnet run integration test TestAboutDotnet
148-
- name: TestDotNetTransformations
149-
run: dotnet run integration test TestDotNetTransformations
150-
- name: TestResourceRefsGetResourceDotnet
151-
run: dotnet run integration test TestResourceRefsGetResourceDotnet
152-
- name: TestDotNetAliasesRemame
153-
run: dotnet run integration test TestDotNetAliasesRemame
154-
- name: TestDotNetAliasesAdoptIntoComponent
155-
run: dotnet run integration test TestDotNetAliasesAdoptIntoComponent
156-
- name: TestDotNetAliasesRenameComponentAndChild
157-
run: dotnet run integration test TestDotNetAliasesRenameComponentAndChild
158-
- name: TestDotNetAliasesRetypeComponent
159-
run: dotnet run integration test TestDotNetAliasesRetypeComponent
160-
- name: TestDotNetAliasesRenameComponent
161-
run: dotnet run integration test TestDotNetAliasesRenameComponent
162-
- name: TestDotNetAliasesRetypeParents
163-
run: dotnet run integration test TestDotNetAliasesRetypeParents
164-
- name: TestProvider
165-
run: dotnet run integration test TestProvider
166-
- name: TestDeletedWith
167-
run: dotnet run integration test TestDeletedWith
168-
- name: TestDotNetTransforms
169-
run: dotnet run integration test TestDotNetTransforms
170-
- name: TestFailingTransfomationExitsProgram
171-
run: dotnet run integration test TestFailingTransfomationExitsProgram
172-
- name: TestProviderCall
173-
run: dotnet run integration test TestProviderCall
174-
- name: TestProviderCallInvalidArgument
175-
run: dotnet run integration test TestProviderCallInvalidArgument
176-
- name: TestProviderConstruct
177-
run: dotnet run integration test TestProviderConstruct
178-
- name: TestProviderConstructDependencies
179-
run: dotnet run integration test TestProviderConstructDependencies
180-
- name: TestProviderConstructUnknown
181-
run: dotnet run integration test TestProviderConstructUnknown
118+
echo "netcoredbgpath=$(pwd)/netcoredbg/" >> ${GITHUB_OUTPUT}
119+
- name: Integration tests
120+
if: matrix.os == 'macos-12'
121+
run: PATH="${{ steps.netcoredbg.outputs.netcoredbgpath}}":"$PATH" make test_integration
122+
- name: Integration tests
123+
if: matrix.os != 'macos-12'
124+
run: make test_integration
182125

183126
info:
184127
name: gather

‎Makefile

+3
Original file line numberDiff line numberDiff line change
@@ -6,4 +6,7 @@ install::
66
build::
77
cd pulumi-language-dotnet && ${GO} build .
88

9+
test_integration::
10+
cd integration_tests && gotestsum -- --parallel 1 --timeout 30m ./...
11+
912
.PHONY: install build

0 commit comments

Comments
 (0)