remove nullability but add exception on access

Author: brandonpollack23

sdk/Pulumi/Deployment/Deployment.cs

@@ -85,7 +85,7 @@ internal static IDeploymentInternal InternalInstance
 
         private readonly string _organizationName;
         private readonly string _projectName;
-        private readonly string _rootDirectory;
+        private readonly string? _rootDirectory;
         private readonly string _stackName;
         private readonly bool _isDryRun;
         private readonly ConcurrentDictionary<string, bool> _featureSupport = new ConcurrentDictionary<string, bool>();
@@ -173,7 +173,19 @@ internal Deployment(IEngine engine, IMonitor monitor, TestOptions? options)
 
         string IDeployment.OrganizationName => _organizationName;
         string IDeployment.ProjectName => _projectName;
-        string? IDeployment.RootDirectory => _rootDirectory;
+        string IDeployment.RootDirectory
+        {
+            get
+            {
+              if (_rootDirectory == null)
+              {
+                throw new InvalidOperationException("Root directory is not available in your version of the pulumi CLI, please upgrade to the latest version");
+              }
+
+              return _rootDirectory;
+            }
+        }
+
         string IDeployment.StackName => _stackName;
         bool IDeployment.IsDryRun => _isDryRun;
 

sdk/Pulumi/Deployment/DeploymentInstance.cs

@@ -27,7 +27,7 @@ internal DeploymentInstance(IDeployment deployment)
         /// <summary>
         /// Root directory, that is the location of the Pulumi.yaml file.
         /// </summary>
-        public string? RootDirectory => _deployment.RootDirectory;
+        public string RootDirectory => _deployment.RootDirectory;
 
         /// <summary>
         /// Returns the current organization name.

sdk/Pulumi/Deployment/Deployment_Inline.cs

@@ -17,7 +17,8 @@ private Deployment(IDeploymentBuilder builder, InlineDeploymentSettings settings
 
             _organizationName = settings.Organization ?? "organization";
             _projectName = settings.Project;
-            _rootDirectory = settings.RootDirectory;
+            // TODO(#535) Propagate this from the Construct RPC
+            _rootDirectory = null;
             _stackName = settings.Stack;
             _isDryRun = settings.IsDryRun;
             SetAllConfig(settings.Config, settings.ConfigSecretKeys);