Add attribute to handle deserialization of constructor parameters with name overrides (#231)

* Add attribute to handle deserialization of constructor parameters with name overrides

* changie new

* Update names

* Add a test. Address PR feedback.

* Relocate new attribute

Author: praneetloke

.changes/unreleased/Improvements-231.yaml

@@ -0,0 +1,7 @@
+component: sdk
+kind: Improvements
+body: Add attribute to handle deserialization of constructor parameters with name
+  overrides
+time: 2024-02-17T07:53:37.629486995-08:00
+custom:
+  PR: "231"

CONTRIBUTING.md

@@ -5,6 +5,7 @@ This repo is made up of three main components. The host runtime (pulumi-language
 ## Changelog
 
 Changelog management is done via [`changie`](https://changie.dev/).
+See the [installation](https://changie.dev/guide/installation/) guide for `changie`.
 
 Run `changie new` in the top level directory. Here is an example of what that looks like:
 
@@ -25,4 +26,4 @@ $ changie batch auto
 $ changie merge
 $ git add .
 $ git commit -m "Changelog for $(changie latest)"
-```
+```

sdk/Pulumi.Tests/Serialization/ConstructorParamAttributeTests.cs

@@ -0,0 +1,40 @@
+// Copyright 2016-2024, Pulumi Corporation
+
+using System;
+using System.Collections.Generic;
+using System.Collections.Immutable;
+using System.Linq;
+using System.Threading.Tasks;
+using Pulumi.Serialization;
+using Xunit;
+
+namespace Pulumi.Tests.Serialization
+{
+    public class ConstructorParamAttributeTests : ConverterTests
+    {
+        [OutputType]
+        public class MyResource
+        {
+            public readonly string StringProp;
+
+            [OutputConstructor]
+            public MyResource([OutputConstructorParameter("string_prop")] string stringProp)
+            {
+                StringProp = stringProp;
+            }
+        }
+
+        [Fact]
+        public async Task TestOutputConstructorParameter()
+        {
+            var warnings = new List<string>();
+
+            var data = Converter.ConvertValue<MyResource>(warnings.Add, "", await SerializeToValueAsync(new Dictionary<string, object>
+            {
+                { "string_prop", "somevalue" },
+            }));
+
+            Assert.Equal("somevalue", data.Value.StringProp);
+        }
+    }
+}

sdk/Pulumi/Pulumi.xml

@@ -77,6 +77,21 @@ public sealed class OutputConstructorAttribute : Attribute
     {
     }
 
+    /// <summary>
+    /// Attribute used by a Pulumi Cloud Provider Package to mark
+    /// constructor parameters with a name override.
+    /// </summary>
+    [AttributeUsage(AttributeTargets.Parameter)]
+    public sealed class OutputConstructorParameterAttribute : Attribute
+    {
+        public string Name { get; }
+
+        public OutputConstructorParameterAttribute(string name)
+        {
+            Name = name;
+        }
+    }
+
     /// <summary>
     /// Attribute used by a Pulumi Cloud Provider Package to mark enum types.
     ///

sdk/Pulumi/Serialization/Attributes.cs

@@ -200,11 +200,17 @@ private static (object?, string?) TryConvertObject(Action<string> warn, string c
             for (int i = 0, n = constructorParameters.Length; i < n; i++)
             {
                 var parameter = constructorParameters[i];
+                var parameterName = parameter.Name!;
+                var attribute = parameter.GetCustomAttribute<OutputConstructorParameterAttribute>();
+                if (attribute != null)
+                {
+                    parameterName = attribute.Name;
+                }
 
                 // Note: TryGetValue may not find a value here.  That can happen for things like
                 // unknown vals.  That's ok.  We'll pass that through to 'Convert' and will get the
                 // default value needed for the parameter type.
-                dictionary!.TryGetValue(parameter.Name!, out var argValue);
+                dictionary!.TryGetValue(parameterName, out var argValue);
 
                 arguments[i] = ConvertObject(warn, $"{targetType.FullName}({parameter.Name})", argValue, parameter.ParameterType);
             }