-
Fix this bug: If you open the comment history panel with the Comment Navigator script running, an error occurs and the Google Document doesn't load
-
Clean up the test fixture interface. We should export as little as possible from
src/lib/test-utils/mock-html.ts
. This will make it easier to standardize fixtures across unit tests as well as between unit tests and e2e tests. -
Currently there's no good way to test the navigator against a document with an indefinite number of comment threads. To see how the navigator components render with, say, 1,500 discussions or 50 authors, the current easiest solution is to edit
fixture.yaml
and runnpm run e2e-inspect
. But this doens't play well with the e2e tests as they're currently written. -
When you navigate to a discussion thread in Google Docs, sometimes the default focus behavior will send the thread slightly offscreen. Add some way to direct the user to offscreen threads. Note that one attempt to solve this problem used
scrollBy
to move offscreen threads into view. If this happens during the Google Docs discussion selection animation, the effect is super jarring. The issue isn't severe enough to warrant pervasive scrolljacking. -
Change the minimization flow to reduce the screen real estate of the comment navigator.
- When initially maximized, show only navigation buttons, plus an option to show filters, and the text indicating how many comments remain
- When the “show filters” option is shown, show the filter input components
- This will probably be easiest if we implement the comment navigator as a state machine
-
Give the “selectors” package as little surface area as possible. Add a Comment class and include all attributes of comments/threads we'll use in the navigator as attributes of the Comment/CommentThread/ThreadCollection classes.
-
Property-based testing for all code that takes arbitrary user input (e.g., and especially, new
Filter
s read from UI input components) -
Slider for comment navigation. Each stop becomes another comment. Start by dispatching a click for every stop
-
Filter by comment length and provide an option to navigate threads in descending/ascending length.