Skip to content

Commit 9c51791

Browse files
authored
Merge pull request #20 from psyplot/no-intersphinx-on-win
Disable intersphinx on windows by default
2 parents e0e3214 + 4a9577e commit 9c51791

File tree

5 files changed

+33
-22
lines changed

5 files changed

+33
-22
lines changed

CHANGELOG.rst

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,15 @@
11
v1.3.0
22
======
3+
Presets and more variable info
4+
35
Changed
46
-------
57
- psyplot-gui has been moved from https://github.com/Chilipp/psyplot-gui to https://github.com/psyplot/psyplot-gui,
68
see `#10 <https://github.com/psyplot/psyplot-gui/pull/10>`__
79
- variables in the dataset tree show now more content,
810
see `#16 <https://github.com/psyplot/psyplot-gui/pull/16>`__
11+
- setting the rcparam ``help_explorer.use_intersphinx`` to None, will not use
12+
intersphinx on windows, see `#20 <https://github.com/psyplot/psyplot-gui/pull/20>`__
913

1014
Added
1115
-----

ci/conda-recipe/meta.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ app:
6060

6161
about:
6262
home: https://github.com/psyplot/psyplot-gui
63-
license: GPL-2.0
63+
license: GPL-2.0-only
6464
license_family: GPL
6565
license_file: LICENSE
6666
summary: Graphical user interface for the psyplot package

psyplot_gui/config/rcsetup.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -187,7 +187,8 @@ def format_ep(ep):
187187
'Use the intersphinx extension and link to the online documentations '
188188
'of matplotlib, pyplot, psyplot, numpy, etc. when converting rst '
189189
'docstrings. The inventories are loaded when the first object is '
190-
'documented. If None, intersphinx is only used with PyQt5'],
190+
'documented. If None, intersphinx is only used when '
191+
'`help_explorer.online` is True and you are not using windows'],
191192
'help_explorer.render_docs_parallel': [
192193
True, validate_bool,
193194
'Boolean whether the html docs are rendered in a separate process'],

psyplot_gui/sphinx_supp/conf.py

Lines changed: 16 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -12,13 +12,13 @@
1212
# All configuration values have a default; values that are commented out
1313
# serve to show the default.
1414

15+
import sys
1516
import sphinx
1617
import sphinx_rtd_theme
1718
import re
1819
import six
1920
from itertools import product
2021
import psyplot_gui
21-
from psyplot_gui.compat.qtcompat import with_qt5
2222

2323
# -- General configuration ------------------------------------------------
2424

@@ -31,9 +31,16 @@
3131
'sphinx.ext.viewcode',
3232
'psyplot.sphinxext.extended_napoleon',
3333
]
34-
use_intersphinx = (psyplot_gui.rcParams['help_explorer.online'] and
35-
psyplot_gui.rcParams['help_explorer.use_intersphinx'])
36-
if use_intersphinx or (use_intersphinx is None and with_qt5):
34+
35+
if psyplot_gui.rcParams['help_explorer.use_intersphinx'] is None:
36+
if sys.platform.startswith("win"):
37+
use_intersphinx = False
38+
else:
39+
use_intersphinx = psyplot_gui.rcParams['help_explorer.online']
40+
else:
41+
use_intersphinx = psyplot_gui.rcParams['help_explorer.use_intersphinx']
42+
43+
if use_intersphinx:
3744
extensions.append('sphinx.ext.intersphinx')
3845
del use_intersphinx
3946

@@ -98,20 +105,11 @@
98105

99106
# The theme to use for HTML and HTML Help pages. See the documentation for
100107
# a list of builtin themes.
101-
if with_qt5:
102-
html_theme = 'sphinx_rtd_theme'
103-
html_theme_path = [sphinx_rtd_theme.get_html_theme_path()]
104-
html_theme_options = {
105-
'prev_next_buttons_location': None
106-
}
107-
108-
else:
109-
html_theme = 'alabaster'
110-
111-
# Theme options are theme-specific and customize the look and feel of a
112-
# theme further. For a list of options available for each theme, see the
113-
# documentation.
114-
html_theme_options = {'nosidebar': True}
108+
html_theme = 'sphinx_rtd_theme'
109+
html_theme_path = [sphinx_rtd_theme.get_html_theme_path()]
110+
html_theme_options = {
111+
'prev_next_buttons_location': None
112+
}
115113

116114
# Add any paths that contain custom static files (such as style sheets) here,
117115
# relative to this directory. They are copied after the builtin static files,

setup.py

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,15 +40,18 @@ def run_tests(self):
4040
'Topic :: Scientific/Engineering :: GIS',
4141
'Topic :: Scientific/Engineering',
4242
'License :: OSI Approved :: GNU General Public License v2 (GPLv2)',
43+
'Programming Language :: Python :: 3',
44+
'Programming Language :: Python :: 3 :: Only',
4345
'Programming Language :: Python :: 3.6',
4446
'Programming Language :: Python :: 3.7',
47+
'Programming Language :: Python :: 3.8',
4548
'Operating System :: OS Independent',
4649
],
4750
keywords=('visualization netcdf raster cartopy earth-sciences pyqt qt '
4851
'ipython jupyter qtconsole'),
4952
url='https://github.com/psyplot/psyplot-gui',
50-
author='Philipp Sommer',
51-
author_email='philipp.sommer@unil.ch',
53+
author='Philipp S. Sommer',
54+
author_email='philipp.sommer@hzg.de',
5255
license="GPLv2",
5356
packages=find_packages(exclude=['docs', 'tests*', 'examples']),
5457
install_requires=[
@@ -65,6 +68,11 @@ def run_tests(self):
6568
osp.join('psyplot_gui', 'icons', '*.png'),
6669
osp.join('psyplot_gui', 'icons', '*.svg'),
6770
]},
71+
project_urls={
72+
'Documentation': 'https://psyplot.readthedocs.io/projects/psyplot-gui',
73+
'Source': 'https://github.com/psyplot/psyplot-gui',
74+
'Tracker': 'https://github.com/psyplot/psyplot-gui/issues',
75+
},
6876
include_package_data=True,
6977
tests_require=['pytest', 'psutil'],
7078
cmdclass={'test': PyTest},

0 commit comments

Comments
 (0)