Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turkish small caps return wrong glyph #38

Open
alerque opened this issue Nov 4, 2023 · 8 comments
Open

Turkish small caps return wrong glyph #38

alerque opened this issue Nov 4, 2023 · 8 comments

Comments

@alerque
Copy link

alerque commented Nov 4, 2023

When the language is set to Turkish, the small caps feature should return a dotted-i glyph for i inputs. See this example were ElstobD (v2.201) fails to do so and returns an undotted-i shape instead as in English. The second example line here is Brill, which is correct:

\begin[papersize=a7]{document}
\nofolios
\font[family=ElstobD,language=en,features=+smcp]{First Input: }
\font[family=ElstobD,language=tr,features=+smcp]{Bir İlk Ilık}

\font[family=Brill,language=en,features=+smcp]{First Input: }
\font[family=Brill,language=tr,features=+smcp]{Bir İlk Ilık}
\end{document}

20231104_16h02m14s_grim

@alerque
Copy link
Author

alerque commented Nov 4, 2023

Come to think of it, the lowercase undotted-i is also wrong. It's correctly dotless but it is not a capital shape at all, that should be mapped to the same capital a small caps i would give in English.

@psb1558
Copy link
Owner

psb1558 commented Nov 4, 2023

Come to think of it, the lowercase undotted-i is also wrong. It's correctly dotless but it is not a capital shape at all, that should be mapped to the same capital a small caps i would give in English.

You mean when smcp is active? If so, I see I got the second case wrong not only here, but also in Junicode.

@alerque
Copy link
Author

alerque commented Nov 4, 2023

Yes, lowercase dotless-i (ı) when rendered with +smcp is not returning a small caps glyph, it is just the same one as it was. Note the 3rd letter in Ilık. Elstob is showing the regular lower case shape. The shape that should be shown is the same glyph as used in English for a capital I without a dot, but small cap sized of course.

@psb1558
Copy link
Owner

psb1558 commented Nov 4, 2023

Thanks. That's what I thought, but I wanted to make sure it was straight in my head. Fixing now.

@psb1558
Copy link
Owner

psb1558 commented Nov 4, 2023

I've uploaded just the variable fonts. Before I make a release, would you mind grabbing them and making sure I've got them right?

@psb1558
Copy link
Owner

psb1558 commented Nov 5, 2023

I've uploaded new copies of the variable fonts after checking out the capitals with c2sc and fixing (or trying to fix) the fi and ffi ligatures. If you could check those things out, I'd be very grateful. In particular, a dotted i following f keeps its dot, and the narrow form of f is substituted. I'm pretty sure this is right:
image
But what should happen with dotless i? Should it be like this
image
or more like this (looking less like a ligature)?
image

@alerque
Copy link
Author

alerque commented Nov 6, 2023

Using the variable font build from cea8879 the results look correct. Updated test case using a local font file directly:

\begin[papersize=a7]{document}
\nofolios
\font[filename=./Elstob.ttf,language=en,features=+smcp]{First Input: }
\font[filename=./Elstob.ttf,language=tr,features=+smcp]{Bir İlk Ilık}

\font[family=Brill,language=en,features=+smcp]{First Input: }
\font[family=Brill,language=tr,features=+smcp]{Bir İlk Ilık}
\end{document}

20231106_13h03m48s_grim

@psb1558
Copy link
Owner

psb1558 commented Nov 6, 2023

Okay, thanks for testing. I'll update the repository and prepare a release sometime today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants