Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Make OPL more robust for unacceptable ISO files #1440

Open
1 task done
fiddybux opened this issue Dec 31, 2024 · 14 comments
Open
1 task done

[FR] Make OPL more robust for unacceptable ISO files #1440

fiddybux opened this issue Dec 31, 2024 · 14 comments

Comments

@fiddybux
Copy link

Checks

Describe the FR

I'm new to OPL and have been plagued with issues of getting it to work over Samba with my PS2 slim...the main issue being hanging. I traced the issue to bad ISOs (typically PS1 files in ISO format due to newbie error). If I stick a PS1 file in ISO format in DVD folder, OPL just freezes when loading share over SMB. For context, I'm doing it via my router share to a connected USB HDD, which is in my mind the more elegant solution than mass storage option.

Describe the solution you'd like

OPL should time out or skip or not crash. Better yet would be a scan for bad ISO so users can tell where the culprit lies.

Describe alternatives you've considered

I have none.

Additional context

PS2 slim, OPL 1.1.0, FMCB latest, SMB, Router, USB HDD (or stick or any USB storage device via router - so NTFS etc is fine).

@Jaajees
Copy link

Jaajees commented Jan 1, 2025

The OPL does not compatible with PS1 games converted to ISO

The best alternatives would be DKWRV or POPStarter, try to find out about these homebrews, I hope I helped

@Jaajees
Copy link

Jaajees commented Jan 1, 2025

But an error message saying "ISO file not compatible" would be a good thing

@fiddybux
Copy link
Author

fiddybux commented Jan 1, 2025

Yes, a message would be helpful, or a graceful exit, just not a hang. It would help new users a great deal.

@Jaajees
Copy link

Jaajees commented Jan 1, 2025

@AKuHAK What do you think?

@AKuHAK
Copy link
Member

AKuHAK commented Jan 1, 2025

@AKuHAK What do you think?

This is implement in NHDDL

@fiddybux
Copy link
Author

fiddybux commented Jan 1, 2025

Thanks chaps! 💯 %

@Jaajees
Copy link

Jaajees commented Jan 5, 2025

Yes, a message would be helpful, or a graceful exit, just not a hang. It would help new users a great deal.

What would be a good "graceful exit"?

Perhaps, by detecting that the item cannot be executed and notifying the user of this inability, OPL could simply re-boot itself.

@fiddybux
Copy link
Author

fiddybux commented Jan 5, 2025 via email

@Jaajees
Copy link

Jaajees commented Jan 5, 2025

@fiddybux
Like this
20250105_123433

@fiddybux
Copy link
Author

fiddybux commented Jan 5, 2025

Yes, that is perfect. Much more helpful. Ultimately, it would be even more helpful if it could flag the item which couldn't be loaded and then print the filename in the dialogue. This would make removing it easier. I had to backtrack one by one to find the item which caused the crash.

@fiddybux
Copy link
Author

fiddybux commented Jan 5, 2025

@fiddybux
Like this
20250105_123433

..and can I just also add that I'm very grateful that you guys are taking this suggestion on board. I cannot thank you enough. 😎🤩

@Jaajees
Copy link

Jaajees commented Jan 6, 2025

@fiddybux
Assim
20250105_123433

..e posso acrescentar que estou muito grato que vocês estejam aceitando essa sugestão. Não posso agradecer o suficiente. 😎🤩

Calm down, this is a notification that already exists in OPL, I just simulated an error.

Your FR was not implemented

@Jaajees
Copy link

Jaajees commented Jan 6, 2025

@fiddybux
more accurate way to notify you about what error is happening with the item being executed.

Using as an example PS1 games that were simply converted to ISO:
-Error, item (ItemName) cannot be executed because it (origin of the problem)

(or something like that)

@Jaajees
Copy link

Jaajees commented Jan 8, 2025

Then @AKuHAK

In short, we need more "precise error messages" that indicate what the problem is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants