You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Update emsdk version to 3.1.67 in Bazel configuration
This CL mostly follows the instructions in
https://github.com/emscripten-core/emsdk/blob/main/bazel/README.md.
Even so, there are a few things that are worth mentioning:
1. I tested the changes locally and in my tests
incompatible_enable_cc_toolchain_resolution bazel flag made no
difference (e.g. everything builds with or without the flag);
I still keep it though because instructions say that it should
be there and it does not cause any harm.
2. I don't think that we still need to patch emsdk to exclude npm
modules from the toolchain, because it appears that upstream
already removed those as a toolchain dependency in
emscripten-core/emsdk#1045.
It's worth noting, that even though I don't think that emsdk patch
is still needed, I actually wasn't able to reproduce the problem
reported in #149
locally without the emsdk.patch even with the current version of
emsdk used by C++ SDK.
Signed-off-by: Mikhail Krinkin <[email protected]>
0 commit comments