bazel: migrate to hedron compile-commands-extractor; update generator and docs #465
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmorel-35
requested review from
PiotrSikora,
leonm1,
martijneken and
mpwarres
as code owners
… and docs
Replace the unmaintained `bazel_compdb` with the Hedron
`bazel-compile-commands-extractor` and adapt the workspace tooling.
- Add `http_archive` for Hedron in `bazel/repositories.bzl` (pinned sha256).
- Add a convenience `refresh_compile_commands` target to the workspace `BUILD`.
- Update `tools/gen_compilation_database.py`:
- Prefer calling the external extractor (`@hedron_compile_commands//:refresh_all`) by default.
- Forward boolean flags (`--include_external`, `--include_genfiles`,
`--include_headers`, `--include_all`, `--system-clang`) to the extractor.
- Remove automatic fallback to a workspace-root `:refresh_compile_commands` and
emit a clear error if the external extractor fails.
- Best-effort cleanup of temporary files created for per-target runs.
- Update `DEVELOPMENT.md` with concise English instructions, examples and useful links
for generating `compile_commands.json`.
- Run basic validation: built and ran the extractor and verified `compile_commands.json`
is produced for both workspace-wide and per-target invocations.
Signed-off-by: Matthieu MOREL <[email protected]>
mmorel-35
force-pushed
the
bazel-compile-commands-extractor
branch
from
d50460d to
135d081
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the unmaintained
bazel_compdbwith the Hedronbazel-compile-commands-extractorand adapt the workspace tooling.http_archivefor Hedron inbazel/repositories.bzl(pinned sha256).refresh_compile_commandstarget to the workspaceBUILD.tools/gen_compilation_database.py:@hedron_compile_commands//:refresh_all) by default.tmp_refresh_compile_commandstarget (avoids forwarding targets directly to the extractor which can breakbazel aquery).--include_external,--include_genfiles,--include_headers,--include_all,--system-clang) to the extractor.:refresh_compile_commandsand emit a clear error if the external extractor fails.DEVELOPMENT.mdwith concise English instructions, examples and useful links for generatingcompile_commands.json.compile_commands.jsonis produced for both workspace-wide and per-target invocations.