fix: remove racy call to isolate->IsExecutionTerminating()

leonm1 · leonm1 · commit 619bf90ed936 · 2025-07-18T09:57:33.000-04:00
Signed-off-by: Matt Leon &lt;mattleon@google.com&gt;
diff --git a/src/v8/v8.cc b/src/v8/v8.cc
@@ -706,9 +706,6 @@ void V8::terminate() {
   auto *store_impl = reinterpret_cast<wasm::StoreImpl *>(store_.get());
   auto *isolate = store_impl->isolate();
   isolate->TerminateExecution();
-  while (isolate->IsExecutionTerminating()) {
-    std::this_thread::yield();
-  }
 }
 
 std::string V8::getFailMessage(std::string_view function_name, wasm::own<wasm::Trap> trap) {

Original file line number	Diff line number	Diff line change
`@@ -706,9 +706,6 @@ void V8::terminate() {`
`706`	`706`	`auto store_impl = reinterpret_cast<wasm::StoreImpl >(store_.get());`
`707`	`707`	`auto *isolate = store_impl->isolate();`
`708`	`708`	`isolate->TerminateExecution();`
`709`		`- while (isolate->IsExecutionTerminating()) {`
`710`		`- std::this_thread::yield();`
`711`		`- }`
`712`	`709`	`}`
`713`	`710`
`714`	`711`	`std::string V8::getFailMessage(std::string_view function_name, wasm::own<wasm::Trap> trap) {`