Added upb_EpsCopyInputStream_ReadEphemeral() and removed other functions that it can replace.
#24625
+96
−129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tions that it can replace. - `upb_EpsCopyInputStream_Skip()` is equivalent to calling `upb_EpsCopyInputStream_ReadEphemeral()` and ignoring the returned string view. - `upb_EpsCopyInputStream_Copy()` is equivalent to calling `upb_EpsCopyInputStream_ReadEphemeral()` and then `memcpy()`-ing the contents manually. Also changed the return type of `PushLimit()` from `int` to `ptrdiff_t`. Since the stream accepts a `size_t` length for the input buffer, the delta can exceed `INT_MAX`. For example, if the input buffer is 3G and the user calls `PushLimit(1)`, then the delta will be almost 3G. PiperOrigin-RevId: 837693748
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
upb_EpsCopyInputStream_ReadEphemeral()and removed other functions that it can replace.upb_EpsCopyInputStream_Skip()is equivalent to callingupb_EpsCopyInputStream_ReadEphemeral()and ignoring the returned string view.upb_EpsCopyInputStream_Copy()is equivalent to callingupb_EpsCopyInputStream_ReadEphemeral()and thenmemcpy()-ing the contents manually.Also changed the return type of
PushLimit()frominttoptrdiff_t. Since the stream accepts asize_tlength for the input buffer, the delta can exceedINT_MAX. For example, if the input buffer is 3G and the user callsPushLimit(1), then the delta will be almost 3G.