-
Notifications
You must be signed in to change notification settings - Fork 81
Open
Labels
help wantedExtra attention is neededExtra attention is neededpackaging & distributiontriagedIssue has been triagedIssue has been triaged
Description
goog.DEBUG is true
in the google-protobuf.js
runtime distributed in the npm
package. This setting gates the various assertion code in the runtime (goog.asserts.ENABLE_ASSERTS = goog.DEBUG;
).
- Is this expected?
- If so, should DEBUG be set to false for production builds? And should two builds be distributed, or a means be exposed to configure this?
- If not, should the gulpfile that generates the runtime supply
--define goog.DEBUG=false
to the closure compiler invocation?
thielepaul
Metadata
Metadata
Assignees
Labels
help wantedExtra attention is neededExtra attention is neededpackaging & distributiontriagedIssue has been triagedIssue has been triaged